Add validations when materializing from file sources - #1615
Merged
feast-ci-bot merged 2 commits intoJun 3, 2021
Merged
Conversation
Signed-off-by: Achal Shah <achals@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #1615 +/- ##
==========================================
+ Coverage 83.57% 83.64% +0.07%
==========================================
Files 65 67 +2
Lines 5771 5816 +45
==========================================
+ Hits 4823 4865 +42
- Misses 948 951 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: Achal Shah <achals@gmail.com>
achals
changed the title
woop
approved these changes
Jun 3, 2021
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, woop The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
/lgtm |
woop
pushed a commit
that referenced
this pull request
Jun 7, 2021
* Validate join keys when materializing from file sources Signed-off-by: Achal Shah <achals@gmail.com> * Dedupe columns when extracting from the dataframe Signed-off-by: Achal Shah <achals@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Achal Shah achals@gmail.com
What this PR does / why we need it:
This PR validate join keys when materializing from file sources, to make sure that the join keys are present in the dataframe columns. Additionally, we dedupe column names when extracting columns from the pandas dataframe. This should specifically catch the case of
event_timestamp_columnandcreated_timestamp_columnpointing to the same column name.Additionally, this fixes a bug where the
EntityNotFoundExceptionwas instantiated with the entity name and project name switched.Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: