Skip to content

Integration test#130

Closed
zhilingc wants to merge 53 commits into
feast-dev:masterfrom
zhilingc:integration-test
Closed

Integration test#130
zhilingc wants to merge 53 commits into
feast-dev:masterfrom
zhilingc:integration-test

Conversation

@zhilingc

Copy link
Copy Markdown
Collaborator

More or less done, making the PR first. Added integration test that runs the following steps on argo:

  1. build cli
  2. provision infra with TF
  3. run pytest which:
    a. registers necessary specs
    b. runs job
    c. checks the output against expected values

currently the repository is pointing to my fork, will change over to the main repository when the changes are complete

@feast-ci-bot

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: zhilingc

If they are not already assigned, you can assign the PR to them by writing /assign @zhilingc in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zhilingc

Copy link
Copy Markdown
Collaborator Author

/hold

@tims

tims commented Feb 14, 2019

Copy link
Copy Markdown
Contributor

Can you add a short Integration Tests section to the testing/readme that describes the whole sequence in english?

And a part that points to where we should start if we want to add new integration tests?

@zhilingc

Copy link
Copy Markdown
Collaborator Author

Can you add a short Integration Tests section to the testing/readme that describes the whole sequence in english?

And a part that points to where we should start if we want to add new integration tests?

I've added some readmes but I'm in the process of figuring out a way of easily extending what's already there... any ideas?

zhilingc and others added 27 commits March 1, 2019 00:42
Fix to bucket accessible by the project running the integration test
Also ignore duplicate rows when retrieving actual test data result from warehouse so jobs can run multiple times on the same cluster and thes test still succeed
To customize the machine type for the node pools
@zhilingc zhilingc mentioned this pull request Mar 29, 2019
@zhilingc zhilingc closed this Mar 29, 2019
aniketpalu pushed a commit to aniketpalu/feast that referenced this pull request Dec 26, 2025
Signed-off-by: konflux-internal-p02 <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
Co-authored-by: konflux-internal-p02[bot] <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants