Skip to content

Fix github workflow deprecating env variable - #1158

Merged
pyalex merged 1 commit into
feast-dev:masterfrom
terryyylim:fix-gh-workflow-deprecation
Nov 13, 2020
Merged

Fix github workflow deprecating env variable#1158
pyalex merged 1 commit into
feast-dev:masterfrom
terryyylim:fix-gh-workflow-deprecation

Conversation

@terryyylim

Copy link
Copy Markdown
Member

Signed-off-by: Terence terencelimxp@gmail.com

What this PR does / why we need it:
Github actions will be deprecating set-env as described in this blog post. Thus, we need to update it before it causes issues to our ci/cd.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Terence <terencelimxp@gmail.com>
--output-dir .
- name: Get version
run: echo ::set-env name=RELEASE_VERSION::${GITHUB_REF#refs/*/}
run: echo "RELEASE_VERSION=${GITHUB_REF#refs/*/}" >> $GITHUB_ENV

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really sure what this command now does...

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recommended upgrade from github workflow docs.

@terryyylim

Copy link
Copy Markdown
Member Author

/retest

@feast-ci-bot

feast-ci-bot commented Nov 12, 2020

Copy link
Copy Markdown
Collaborator

@terryyylim: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
test-end-to-end-aws adbaaeb link /test test-end-to-end-aws
test-end-to-end-gcp adbaaeb link /test test-end-to-end-gcp

Full PR test history

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@feast-ci-bot

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pyalex, terryyylim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pyalex
pyalex merged commit 825c334 into feast-dev:master Nov 13, 2020
pyalex pushed a commit that referenced this pull request Nov 24, 2020
Signed-off-by: Terence <terencelimxp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants