Skip to content

Fix helm repo addition and dockerhub path context #1155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
woop merged 2 commits into from
Nov 11, 2020
Merged

Fix helm repo addition and dockerhub path context #1155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
391e45b
Fix helm repo addition and dockerhub path context
terryyylim Nov 11, 2020
3304b63
Fix env variable access and context
terryyylim Nov 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,10 +80,11 @@ jobs:
RELEASE_VERSION: ${{ needs.get-version.outputs.release_version }}
with:
push: true
file: infra/docker/${{ matrix.component }}/Dockerfile
context: .
file: ./infra/docker/${{ matrix.component }}/Dockerfile
tags: feastdev/feast-${{ matrix.component }}:${{ needs.get-version.outputs.release_version }}
build-args: |
REVISION=${RELEASE_VERSION}
REVISION=$RELEASE_VERSION
- name: Build and push latest
uses: docker/build-push-action@v2
env:
Expand All @@ -93,10 +94,11 @@ jobs:
with:
if: ${VERSION_WITHOUT_PREFIX} == ${HIGHEST_SEMVER_TAG:1}
push: true
file: infra/docker/${{ matrix.component }}/Dockerfile
context: .
file: ./infra/docker/${{ matrix.component }}/Dockerfile
tags: feastdev/feast-${{ matrix.component }}:latest
build-args: |
REVISION=${RELEASE_VERSION}
REVISION=$RELEASE_VERSION

publish-helm-charts:
runs-on: ubuntu-latest
Expand Down
2 changes: 1 addition & 1 deletion infra/scripts/sync-helm-charts.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ fi

exit_code=0

helm repo add bitnami bitnami https://charts.bitnami.com/bitnami
helm repo add bitnami https://charts.bitnami.com/bitnami

for dir in "$repo_dir"/*; do
if helm dep update "$dir" && helm dep build "$dir"; then
Expand Down