Skip to content

Make created_timestamp property optional in KafkaSource #1146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 1 commit into from
Nov 9, 2020
Merged

Make created_timestamp property optional in KafkaSource #1146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdk/python/feast/data_source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -611,10 +611,10 @@ class KafkaSource(DataSource):
def __init__(
self,
event_timestamp_column: str,
created_timestamp_column: str,
bootstrap_servers: str,
message_format: StreamFormat,
topic: str,
created_timestamp_column: Optional[str] = "",
field_mapping: Optional[Dict[str, str]] = dict(),
date_partition_column: Optional[str] = "",
):
Expand Down
1 change: 0 additions & 1 deletion sdk/python/tests/test_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,7 +411,6 @@ def test_apply_feature_table_success(self, test_client):
message_format=ProtoFormat("class.path"),
topic="test_topic",
event_timestamp_column="ts_col",
created_timestamp_column="timestamp",
)

ft1 = FeatureTable(
Expand Down
1 change: 0 additions & 1 deletion sdk/python/tests/test_feature_table.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,6 @@ def test_feature_table_import_export_yaml(self, batch_source):
message_format=ProtoFormat(class_path="class.path"),
topic="test_topic",
event_timestamp_column="ts_col",
created_timestamp_column="timestamp",
)

test_feature_table = FeatureTable(
Expand Down
2 changes: 1 addition & 1 deletion spark/ingestion/src/main/scala/feast/ingestion/BasePipeline.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ trait BasePipeline {
jobConfig.stencilURL match {
case Some(url: String) =>
conf
.set("feast.ingestion.registry.proto.kind", "local")
.set("feast.ingestion.registry.proto.kind", "stencil")
.set("feast.ingestion.registry.proto.url", url)
case None => ()
}
Expand Down
7 changes: 3 additions & 4 deletions tests/e2e/test_online_features.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,10 +119,9 @@ def test_streaming_ingestion(
file_url=os.path.join(local_staging_path, "batch-storage"),
),
stream_source=KafkaSource(
"event_timestamp",
"event_timestamp",
kafka_broker,
AvroFormat(avro_schema()),
event_timestamp_column="event_timestamp",
bootstrap_servers=kafka_broker,
message_format=AvroFormat(avro_schema()),
topic=topic_name,
),
)
Expand Down
1 change: 0 additions & 1 deletion tests/e2e/test_register.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,6 @@ def basic_featuretable():
message_format=ProtoFormat(class_path="class.path"),
topic="test_topic",
event_timestamp_column="datetime_col",
created_timestamp_column="timestamp",
)
return FeatureTable(
name="basic_featuretable",
Expand Down