Skip to content

Most Unit Tests are not Running on feast.core package. #882

@mrzzy

Description

@mrzzy

Expected Behavior

When running mvn test to run tests, only one test class was running under the feast.core package:

[INFO]                                                                                                                                                                                                       
[INFO] --- spotless-maven-plugin:1.26.1:check (spotless-check) @ feast-core ---                                                                                                                              
[INFO]                                                                                                                                                                                                       
[INFO] --- maven-surefire-plugin:3.0.0-M4:test (default-test) @ feast-core ---                                                                                                                               
[INFO]                                                                                                                                                                                                       
[INFO] -------------------------------------------------------                                                                                                                                               
[INFO]  T E S T S                                                                                                                                                                                            
[INFO] -------------------------------------------------------                                                                                                                                               
[INFO] Running feast.core.grpc.CoreServiceAuthTest                                                                                                                                                           
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.255 s - in feast.core.grpc.CoreServiceAuthTest                                                                                      
[INFO]                                                                                                                                                                                                       
[INFO] Results:                                                                                                                                                                                              
[INFO]                                                                                                                                                                                                       
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0                                                                                                                                                      
[INFO]                                                                                                                                                                                                       

This is unexpected as there a ton more tests under core/src/test/java/feast/core/. The rest of the unit tests should be running.

Cause

Investigation points to the new JUnit 5 (org.junit.jupiter) test harness added to Core's pom.xml in #793

  • CoreServiceAuthTest is annotated with @Test from org.junpiter.api.Test
  • All other tests are using the old @Test: org.junit.Test

Proposed Solution

Revert addition JUnit 5 on Feast Core and update CoreServiceAuthTest to use old @Test.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions