Expected Behavior

On-demand feature views (ODFVs) with write_to_online_store=True should be materialized to the online store, but they should never be queried from the offline store (ODFVs, no data for them in the offline store).

Current Behavior

ODFVs with write_to_online_store=True are being queried from offline stores. In the code here
, if an ODFV has the write_to_online_store flag set, it is treated as a regular feature view. As a result, it gets queried from the offline store.

However, ODFVs are not historical feature views and do not have any data in offline stores, so they should never be queried there.

Steps to reproduce

Run get_historical_features for an ODFV with write_to_online_store=True.

Specifications

• Version: 0.57.0
• Clickhouse offline store.

Possible Solution

Not sure yet, but basically remove the condition? Is it even needed here? Seems incorrect...