Skip to content

Remove GCP dependency in test_get_batch_features #562

@woop

Description

@woop

Expected Behavior

Python unit tests should not depend on GCP service accounts being available

Current Behavior

Currently the test test_get_batch_features in the Python SDK leads to a failure when it is run from an environment where GOOGLE_APPLICATION_CREDENTIALS are not available, or it cannot infer a local Gcloud configuration. This is triggered because the Job object initializes itself with a storage client that requires GCP credentials.

For the time being this test has been commented out, please see this PR https://github.com/gojek/feast/pull/560/files#r396175767

Steps to reproduce

  1. Uncomment above test
  2. Execute from a clean environment (kf-feast/feast-ci:latest docker image)

Possible Solution

  • Stub out the storage client in the unit test.
  • Alternatively we should make the Job object not initialize a Storage Client.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions