-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Labels
kind/featureNew feature or requestNew feature or request
Description
This issue we are creating to track the suggestions recommended by feast community member - @MattDelac
I wanted to drop some feedback and notes here about my experience:
- The generated template doesn't contain .gitignore for feast
- The generated template does not contain any pyproject.toml or requirements file, this is something I'd expect from a scaffolding script for a python-based codebase
- The quickstart guide doesn't mention anything about instantiating a new virtual environment, this is also something I'd expect
- If feast is meant to by an executable, I'd recommend instructing users to install it via pipx instead of pip.
- How do I start the feast server? Do I even start it? It's not clear to me
- The feast init generated templates use absolute paths for some files instead of relative paths. I usually find this to be confusion/bad as people can codify things about their local machines into code bases without realizing it (ex: the example_repo.py) contains path=/Users/matt/code/pnl/feast-test/feast_test/feature_repo/data")
- not super sure why the generated repo is a python module (contains an init.py file but also has a sub directory/module called feature_repo
- nit: I don't understand why Step 3 has a, b, c, d, and e? Maybe just make it step 3, 4, 5, 6 etc
- Include a description of what Feast is
- What feast includes
- Not defining the fundamental concepts in an easy way
- Project isn't defined under Concepts>Overview
- Entity concept documentation was confusing
- feedback unrelated to docs but would be helpful to add the str, repr and maybe even repr_html methods to the FeatureStore class to make debugging easier
- Another quickstart suggestion: I'd recommend actually including the code itself in the quickstart rather than relying on users to have to run feast init. This reduces friction for new people by allowing them to quickly skim the quickstart and follow along without having to be at their computer and install something (for example if they're on their phone).
It also helps ensure the quickstart guide is at least internally consistent meaning you don't have a situation where the someone updates the generated code but forgets to update the quickstart guide. It also helps ensure the quickstart guide is at least internally consistent meaning you don't have a situation where the someone updates the generated code but forgets to update the quickstart guide.
Metadata
Metadata
Assignees
Labels
kind/featureNew feature or requestNew feature or request