-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Closed
Labels
Description
Expected Behavior
Follow the developer guide to step 9 in the Feast Python SDK / CLI section. Then do step 9, which is to execute the command:
make install-python-ci-dependencies-uv
I expect this to run successfully and install dependencies.
Current Behavior
I run the command from the feast root directory, and I get the error message:
error: File not found: `sdk/python/requirements/py-ci-requirements.txt`
make: *** [install-python-ci-dependencies-uv] Error 2
On inspection, the file sdk/python/requirements/py-ci-requirements.txt doesn't exist, but similar files do:
# output
py3.10-ci-requirements.txt py3.11-ci-requirements.txt py3.9-ci-requirements.txt
py3.10-requirements.txt py3.11-requirements.txt py3.9-requirements.txtMy guess is, the requirement files were updated, but the make command was not.
Steps to reproduce
Verifying this should be as easy as running the command make install-python-ci-dependencies-uv from the feast root directory.
To reproduce exactly, follow the Developer Guide steps to step 9.
Specifications
- Version: 0.40.1
- Platform: Mac
- Subsystem: M2
Possible Solution
A couple of suggestions
- Update the make command to point to an existing requirements file. We would have to pick which one, or have logic behind make determine the python version that is best--perhaps with input from the user.
- Update the developer guide to run
pip install -rsdk/python/requirements/py3.9-ci-requirements.txt, with instruction to substitute the version if needed. (Possiblyuv pipinstead of justpip`).