-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Description
Expected Behavior
When following the development setup instructions as per here, in step 5, you need to run make install-python-ci-dependencies PYTHON=3.8. You would expect this to install the dependencies with no issues.
Current Behavior
When following the development setup instructions as per here, in step 5, you need to run make install-python-ci-dependencies PYTHON=3.8. However, since Cython 3.0 has been recently released, a number of packages now do not install successfully.
Steps to reproduce
Just follow the instructions as per the guide linked above, until you get to the line in step 5 make install-python-ci-dependencies PYTHON=3.8, where most packages will install fine apart from fastavro, pyyaml and pymssql.
Specifications
M2 Mac, python 3.8.12, using venv for virtual environment.
Possible Solution
We can just change the versions of the problem packages in the sdk/python/requirements/py3.8-ci-requirements.txt file. I tried this locally, and everything installs fine, also, units tests and local integration tests still pass as expected (all version updates are patch or minor).
The problem packages are:
fastavro==1.7.4
change from 1.7.4 to 1.8.1 due to Cython 3.0 release: https://github.com/fastavro/fastavro/blob/b63523ffbb8175a0b678f90e5e1840fb0f14d530/ChangeLog#L5
pymssql==2.2.7
change from 2.2.7 to 2.2.8, due to due to Cython 3.0 release
see pymssql/pymssql#827
which also references pymssql/pymssql#803 so use instead pymssql==2.2.8
pyyaml==6.0
has to be >6.0 due to Cython 3.0 release see: OctoPrint/OctoPrint#4854 so use pyyaml==6.0.1
Likely we should also do this for the same file for py3.9 and py3.10 (both ci reqs and just reqs files), as they contain the same versions for those 3 packages.