-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Closed
Labels
Description
Expected Behavior
I would expect that the react app, python server, and docs are consistent in how they implement or (for the docs) describe how the registry is ingested.
Current Behavior
Right now:
- Docs: The docs suggest that the UI loads a JSON dump of the registry
- Python App: The python app appears to use
get_registry_dumpto produce a JSON dump of the registry, butget_registry_dumpis never called. Instead the UI fetches theregistry_protofrom/registry(see here and here). - UI:
useLoadRegistrylooks like it used to parse json -- as in feat: Initial merge of Web UI logic #2352 -- but then chore: Replace zod by protobufjs #3208 replaced thejsonwith the protobuf registry
Steps to reproduce
NA
Specifications
- Version:
main
Possible Solution
If the intent of #3208 was to replace the json registry with the protobuf version, then the solution would be to:
- Update the docs to make this clear
- Update the python
ui_serverso it doesn't appear to produce the JSON dump viaget_registry_dump
Of these solutions, the first (updating docs) is probably the most valuable to the community.