Skip to content

basicConfig is called at the module level #2664

@elshize

Description

@elshize

Expected Behavior

import feast
logging.basicConfig(level=level, format=FORMAT)
logging.error("msg")

should print logging message according to FORMAT

Current Behavior

It uses the format defined in feast at the module level.

Steps to reproduce

Same as in "Expected Behavior"

Specifications

  • Version: 0.18.1
  • Platform: Linux
  • Subsystem: -

Possible Solution

I see that basicConfig is called here:

logging.basicConfig(
so it is possible that simply removing this call here is enough:
logging.basicConfig(

If there are any other entry points that need to set up logging, they should call the function, but the call in __init__.py must be removed.

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions