Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: feast-dev/feast
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 89240fa
Choose a base ref
...
head repository: feast-dev/feast
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: bf0a471
Choose a head ref
  • 2 commits
  • 2 files changed
  • 1 contributor

Commits on Jul 30, 2026

  1. fix: Set FIPS cipher suites before pyarrow.flight import to prevent c… 

    …rash on IBM Power

RHOAIENG-78595

# What this PR does / why we need it:

The Feast offline container crashes in CrashLoopBackOff on FIPS-enabled
OpenShift clusters running IBM Power (ppc64le). The existing FIPS cipher
suite fix (RHOAIENG-70153) set GRPC_SSL_CIPHER_SUITES in `start_server()`,
but pyarrow.flight was already imported at module level. On IBM Power, gRPC
reads this env var during shared-library initialization, so the late
configuration had no effect.

This fix moves the FIPS cipher configuration to module level — before the
pyarrow.flight import — so the env var is present when gRPC initializes its
SSL context. The `_configure_grpc_fips()` call in `start_server()` is
retained as a safety net.

# Which issue(s) this PR fixes:

Fixes RHOAIENG-78595

# Checks
- [x] I've made sure the tests are passing.
- [x] My PR title follows conventional commits format

## Testing Strategy
- [x] Unit tests

Assisted-by: Claude claude-opus-4-6 <noreply@anthropic.com>
Signed-off-by: aipcc-bot <aipcc-bot@redhat.com>
Signed-off-by: Jitendra Yejare <11752425+jyejare@users.noreply.github.com>
    aipcc-bot @ntkathole
    aipcc-bot authored and ntkathole committed Jul 30, 2026
    Configuration menu
    Copy the full SHA
    3651e1e View commit details
    Browse the repository at this point in the history

  2. fix: Address review feedback on FIPS cipher suite configuration 

    # What this PR does / why we need it:
Move FIPS log message below logger initialization so it is emitted at INFO
level instead of being silently dropped under the default WARNING threshold.
Replace importlib.reload-based import ordering test with a subprocess-based
test that exercises fresh Python import from scratch, ensuring
pyarrow.flight is not cached in sys.modules and the GRPC_SSL_CIPHER_SUITES
ordering check is genuine.

# Which issue(s) this PR fixes:
Fixes RHOAIENG-78595

# Checks
- [x] I've made sure the tests are passing.
- [x] My PR title follows conventional commits format

## Testing Strategy
- [x] Unit tests

Assisted-by: Claude claude-opus-4-6 <noreply@anthropic.com>
Signed-off-by: Jitendra Yejare <11752425+jyejare@users.noreply.github.com>
    aipcc-bot @ntkathole
    aipcc-bot authored and ntkathole committed Jul 30, 2026
    Configuration menu
    Copy the full SHA
    bf0a471 View commit details
    Browse the repository at this point in the history
Loading