Fix OnDemandFeatureView type inference for array types

alexmirrington · alexmirrington · commit feac39c90769 · 2024-06-24T19:40:28.000+10:00
Signed-off-by: Alex Mirrington &lt;alex.mirrington@rokt.com&gt;
diff --git a/sdk/python/feast/transformation/pandas_transformation.py b/sdk/python/feast/transformation/pandas_transformation.py
@@ -44,7 +44,7 @@ def infer_features(self, random_input: dict[str, list[Any]]) -> list[Field]:
             Field(
                 name=f,
                 dtype=from_value_type(
-                    python_type_to_feast_value_type(f, type_name=str(dt))
+                    python_type_to_feast_value_type(f, value=output_df[f].tolist()[0], type_name=str(dt))
                 ),
             )
             for f, dt in zip(output_df.columns, output_df.dtypes)
diff --git a/sdk/python/feast/transformation/python_transformation.py b/sdk/python/feast/transformation/python_transformation.py
@@ -44,7 +44,7 @@ def infer_features(self, random_input: dict[str, list[Any]]) -> list[Field]:
             Field(
                 name=f,
                 dtype=from_value_type(
-                    python_type_to_feast_value_type(f, type_name=type(dt[0]).__name__)
+                    python_type_to_feast_value_type(f, value=dt[0], type_name=type(dt[0]).__name__)
                 ),
             )
             for f, dt in output_dict.items()
diff --git a/sdk/python/feast/transformation/substrait_transformation.py b/sdk/python/feast/transformation/substrait_transformation.py
@@ -64,7 +64,7 @@ def infer_features(self, random_input: dict[str, list[Any]]) -> list[Field]:
             Field(
                 name=f,
                 dtype=from_value_type(
-                    python_type_to_feast_value_type(f, type_name=str(dt))
+                    python_type_to_feast_value_type(f, value=output_df[f].tolist()[0], type_name=str(dt))
                 ),
             )
             for f, dt in zip(output_df.columns, output_df.dtypes)

Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,7 @@ def infer_features(self, random_input: dict[str, list[Any]]) -> list[Field]:`
`44`	`44`	`Field(`
`45`	`45`	`name=f,`
`46`	`46`	`dtype=from_value_type(`
`47`		`- python_type_to_feast_value_type(f, type_name=str(dt))`
	`47`	`+ python_type_to_feast_value_type(f, value=output_df[f].tolist()[0], type_name=str(dt))`
`48`	`48`	`),`
`49`	`49`	`)`
`50`	`50`	`for f, dt in zip(output_df.columns, output_df.dtypes)`
Original file line number	Diff line number	Diff line change
`@@ -64,7 +64,7 @@ def infer_features(self, random_input: dict[str, list[Any]]) -> list[Field]:`
`64`	`64`	`Field(`
`65`	`65`	`name=f,`
`66`	`66`	`dtype=from_value_type(`
`67`		`- python_type_to_feast_value_type(f, type_name=str(dt))`
	`67`	`+ python_type_to_feast_value_type(f, value=output_df[f].tolist()[0], type_name=str(dt))`
`68`	`68`	`),`
`69`	`69`	`)`
`70`	`70`	`for f, dt in zip(output_df.columns, output_df.dtypes)`