Skip to content

Commit faf85e0

Browse files
ntkatholentkathole
committed
fix: Use correct image name in multi-arch imagetools push step
The build-all-docker-images job in master_only.yml was failing for the feature-server-dev matrix entry because the "Push image" step used matrix.target (feature-server-dev) as the image name, while the Makefile target build-feature-server-dev-docker pushes to feature-server. Added an image_name field to the build matrix to decouple the Makefile target name from the registry image name, and updated the "Push image" step to use matrix.image_name. Also pin mcp dependency to <2 in pyproject.toml since mcp 2.0.0 introduced breaking changes to the Server class constructor that are incompatible with the current fastapi_mcp version. Signed-off-by: ntkathole <nikhilkathole2683@gmail.com>
1 parent 8112b1e commit faf85e0

3 files changed

Lines changed: 7 additions & 3 deletions

File tree

‎.github/workflows/master_only.yml‎

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -94,14 +94,17 @@ jobs:
9494
include:
9595
- component: feature-server-dev
9696
target: feature-server-dev
97+
image_name: feature-server
9798
build_args: DOCKER_PUSH=true DOCKER_PLATFORMS=linux/amd64,linux/arm64
9899
push_mode: imagetools
99100
- component: feature-transformation-server
100101
target: feature-transformation-server
102+
image_name: feature-transformation-server
101103
build_args: ""
102104
push_mode: all_tags
103105
- component: feast-operator
104106
target: feast-operator
107+
image_name: feast-operator
105108
build_args: DOCKER_PUSH=true DOCKER_PLATFORMS=linux/amd64,linux/arm64
106109
push_mode: imagetools
107110
env:
@@ -135,7 +138,7 @@ jobs:
135138
- name: Push image
136139
run: |
137140
if [[ "${{ matrix.push_mode }}" == "imagetools" ]]; then
138-
docker buildx imagetools create -t ${REGISTRY}/${{ matrix.target }}:develop ${REGISTRY}/${{ matrix.target }}:${GITHUB_SHA}
141+
docker buildx imagetools create -t ${REGISTRY}/${{ matrix.image_name }}:develop ${REGISTRY}/${{ matrix.image_name }}:${GITHUB_SHA}
139142
else
140-
docker tag ${REGISTRY}/${{ matrix.target }}:${GITHUB_SHA} ${REGISTRY}/${{ matrix.target }}:develop && docker push ${REGISTRY}/${{ matrix.target }} --all-tags
143+
docker tag ${REGISTRY}/${{ matrix.image_name }}:${GITHUB_SHA} ${REGISTRY}/${{ matrix.image_name }}:develop && docker push ${REGISTRY}/${{ matrix.image_name }} --all-tags
141144
fi

‎pixi.lock‎

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎pyproject.toml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@ snowflake = [
139139
"snowflake-connector-python[pandas]>=3.7,<5",
140140
]
141141
sqlite_vec = ["sqlite-vec==v0.1.6"]
142-
mcp = ["fastapi_mcp"]
142+
mcp = ["fastapi_mcp", "mcp>=1.0,<2"]
143143
mlflow = ["mlflow>=2.10.0"]
144144

145145
dbt = ["dbt-artifacts-parser"]

0 commit comments

Comments
 (0)