Skip to content

Commit ebbc86b

Browse files
XuananLeLe Xuan An
authored andcommitted
test: Use localhost for remote offline clients
Signed-off-by: Le Xuan An <anlx@viettel.com.vn>
1 parent 7aebf78 commit ebbc86b

1 file changed

Lines changed: 11 additions & 8 deletions

File tree

  • sdk/python/tests/universal/feature_repos/universal/data_sources

sdk/python/tests/universal/feature_repos/universal/data_sources/file.py

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -372,6 +372,7 @@ def setup(self, registry: RegistryConfig):
372372

373373
self.server_port = free_port()
374374
host = "0.0.0.0"
375+
client_host = "localhost"
375376
cmd = [
376377
"feast",
377378
"-c" + str(repo_path),
@@ -388,11 +389,11 @@ def setup(self, registry: RegistryConfig):
388389
_time_out_sec: int = 60
389390
# Wait for server to start
390391
wait_retry_backoff(
391-
lambda: (None, check_port_open(host, self.server_port)),
392+
lambda: (None, check_port_open(client_host, self.server_port)),
392393
timeout_secs=_time_out_sec,
393394
timeout_msg=f"Unable to start the feast remote offline server in {_time_out_sec} seconds at port={self.server_port}",
394395
)
395-
return "grpc+tcp://{}:{}".format(host, self.server_port)
396+
return "grpc+tcp://{}:{}".format(client_host, self.server_port)
396397

397398
def teardown(self):
398399
super().teardown()
@@ -441,6 +442,7 @@ def setup(self, registry: RegistryConfig):
441442

442443
self.server_port = free_port()
443444
host = "0.0.0.0"
445+
client_host = "localhost"
444446
cmd = [
445447
"feast",
446448
"-c" + str(repo_path),
@@ -461,16 +463,16 @@ def setup(self, registry: RegistryConfig):
461463
_time_out_sec: int = 60
462464
# Wait for server to start
463465
wait_retry_backoff(
464-
lambda: (None, check_port_open(host, self.server_port)),
466+
lambda: (None, check_port_open(client_host, self.server_port)),
465467
timeout_secs=_time_out_sec,
466468
timeout_msg=f"Unable to start the feast remote offline server in {_time_out_sec} seconds at port={self.server_port}",
467469
)
468-
return "grpc+tls://{}:{}".format(host, self.server_port)
470+
return "grpc+tls://{}:{}".format(client_host, self.server_port)
469471

470472
def create_offline_store_config(self) -> FeastConfigBaseModel:
471473
remote_offline_store_config = RemoteOfflineStoreConfig(
472474
type="remote",
473-
host="0.0.0.0",
475+
host="localhost",
474476
port=self.server_port,
475477
scheme="https",
476478
cert=self.tls_cert_path,
@@ -541,6 +543,7 @@ def setup(self, registry: RegistryConfig):
541543

542544
self.server_port = free_port()
543545
host = "0.0.0.0"
546+
client_host = "localhost"
544547
cmd = [
545548
"feast",
546549
"-c" + repo_path,
@@ -557,15 +560,15 @@ def setup(self, registry: RegistryConfig):
557560
_time_out_sec: int = 60
558561
# Wait for server to start
559562
wait_retry_backoff(
560-
lambda: (None, check_port_open(host, self.server_port)),
563+
lambda: (None, check_port_open(client_host, self.server_port)),
561564
timeout_secs=_time_out_sec,
562565
timeout_msg=f"Unable to start the feast remote offline server in {_time_out_sec} seconds at port={self.server_port}",
563566
)
564-
return "grpc+tcp://{}:{}".format(host, self.server_port)
567+
return "grpc+tcp://{}:{}".format(client_host, self.server_port)
565568

566569
def create_offline_store_config(self) -> FeastConfigBaseModel:
567570
remote_offline_store_config = RemoteOfflineStoreConfig(
568-
type="remote", host="0.0.0.0", port=self.server_port
571+
type="remote", host="localhost", port=self.server_port
569572
)
570573
return remote_offline_store_config
571574

0 commit comments

Comments
 (0)