Skip to content

Commit eb61ce7

Browse files
committed
fix: Make timestamp_field_type default to None in FeatureViewQueryContext
Callers that do not use DATE-typed timestamp fields (e.g. Spark offline store tests) should not be forced to pass timestamp_field_type. Adding a default keeps the new field backward-compatible. Signed-off-by: Jonathan Wrede <wrede.jonathan00@gmail.com>
1 parent 6ac64f6 commit eb61ce7

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

sdk/python/feast/infra/offline_stores/offline_utils.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ class FeatureViewQueryContext:
9898
date_partition_column: Optional[
9999
str
100100
] # this attribute is added because partition pruning affects Athena's query performance.
101-
timestamp_field_type: Optional[str]
101+
timestamp_field_type: Optional[str] = None
102102

103103

104104
def get_feature_view_query_context(

0 commit comments

Comments
 (0)