fix: Timestamp formatting and lakehouse-type connector for trino_offline_store. (#5846)

soliverr · franciscojavierarceo · web-flow · commit c2ea7e92ad85 · 2026-01-15T23:11:32.000-05:00
Signed-off-by: Sergey Kryazhevskikh &lt;soliverr@gmail.com&gt;
Co-authored-by: Francisco Javier Arceo &lt;arceofrancisco@gmail.com&gt;
diff --git a/sdk/python/feast/infra/offline_stores/contrib/trino_offline_store/connectors/upload.py b/sdk/python/feast/infra/offline_stores/contrib/trino_offline_store/connectors/upload.py
@@ -56,6 +56,7 @@
     "oracle",
     "redshift",
     "memsql",
+    "lakehouse",
 }
 
 CREATE_SCHEMA_QUERY_TEMPLATE = """
diff --git a/sdk/python/feast/infra/offline_stores/contrib/trino_offline_store/trino.py b/sdk/python/feast/infra/offline_stores/contrib/trino_offline_store/trino.py
@@ -424,11 +424,16 @@ def pull_all_from_table_or_query(
         )
 
         timestamp_filter = get_timestamp_filter_sql(
-            start_date, end_date, timestamp_field, quote_fields=False
+            start_date,
+            end_date,
+            timestamp_field,
+            quote_fields=False,
+            cast_style="timestamp",
+            date_time_separator=" ",
         )
         query = f"""
             SELECT {field_string}
-            FROM {from_expression}
+            FROM ( {from_expression} )
             WHERE {timestamp_filter}
         """
         return TrinoRetrievalJob(

Original file line number	Diff line number	Diff line change
`@@ -56,6 +56,7 @@`
`56`	`56`	`"oracle",`
`57`	`57`	`"redshift",`
`58`	`58`	`"memsql",`
	`59`	`+ "lakehouse",`
`59`	`60`	`}`
`60`	`61`
`61`	`62`	`CREATE_SCHEMA_QUERY_TEMPLATE = """`