Run make format-python to fix formatting issues

Copilot · franciscojavierarceo · Copilot · commit b5041823aad2 · 2026-01-14T17:16:14.000Z
Co-authored-by: franciscojavierarceo &lt;4163062+franciscojavierarceo@users.noreply.github.com&gt;
diff --git a/sdk/python/feast/cli/cli.py b/sdk/python/feast/cli/cli.py
@@ -243,7 +243,9 @@ def endpoint(ctx: click.Context):
     help="Don't validate feature views. Use with caution as this skips important checks.",
 )
 @click.pass_context
-def plan_command(ctx: click.Context, skip_source_validation: bool, skip_validation: bool):
+def plan_command(
+    ctx: click.Context, skip_source_validation: bool, skip_validation: bool
+):
     """
     Create or update a feature store deployment
     """
@@ -269,7 +271,9 @@ def plan_command(ctx: click.Context, skip_source_validation: bool, skip_validati
     help="Don't validate feature views. Use with caution as this skips important checks.",
 )
 @click.pass_context
-def apply_total_command(ctx: click.Context, skip_source_validation: bool, skip_validation: bool):
+def apply_total_command(
+    ctx: click.Context, skip_source_validation: bool, skip_validation: bool
+):
     """
     Create or update a feature store deployment
     """
diff --git a/sdk/python/feast/repo_operations.py b/sdk/python/feast/repo_operations.py
@@ -220,7 +220,12 @@ def parse_repo(repo_root: Path) -> RepoContents:
     return res
 
 
-def plan(repo_config: RepoConfig, repo_path: Path, skip_source_validation: bool, skip_validation: bool = False):
+def plan(
+    repo_config: RepoConfig,
+    repo_path: Path,
+    skip_source_validation: bool,
+    skip_validation: bool = False,
+):
     os.chdir(repo_path)
     repo = _get_repo_contents(repo_path, repo_config.project, repo_config)
     for project in repo.projects:
@@ -352,13 +357,20 @@ def apply_total_with_repo_instance(
     ) = extract_objects_for_apply_delete(project_name, registry, repo)
 
     if store._should_use_plan():
-        registry_diff, infra_diff, new_infra = store.plan(repo, skip_validation=skip_validation)
+        registry_diff, infra_diff, new_infra = store.plan(
+            repo, skip_validation=skip_validation
+        )
         click.echo(registry_diff.to_string())
 
         store._apply_diffs(registry_diff, infra_diff, new_infra)
         click.echo(infra_diff.to_string())
     else:
-        store.apply(all_to_apply, objects_to_delete=all_to_delete, partial=False, skip_validation=skip_validation)
+        store.apply(
+            all_to_apply,
+            objects_to_delete=all_to_delete,
+            partial=False,
+            skip_validation=skip_validation,
+        )
         log_infra_changes(views_to_keep, views_to_delete)
 
 
@@ -397,7 +409,12 @@ def create_feature_store(
         return FeatureStore(repo_path=str(repo), fs_yaml_file=fs_yaml_file)
 
 
-def apply_total(repo_config: RepoConfig, repo_path: Path, skip_source_validation: bool, skip_validation: bool = False):
+def apply_total(
+    repo_config: RepoConfig,
+    repo_path: Path,
+    skip_source_validation: bool,
+    skip_validation: bool = False,
+):
     os.chdir(repo_path)
     repo = _get_repo_contents(repo_path, repo_config.project, repo_config)
     for project in repo.projects:
diff --git a/sdk/python/tests/unit/test_skip_validation.py b/sdk/python/tests/unit/test_skip_validation.py
@@ -8,23 +8,18 @@
 
 Users should be encouraged to report issues on GitHub when they need to use this flag.
 """
-from datetime import timedelta
-from typing import Any, Dict
 
-import pandas as pd
-import pytest
+from datetime import timedelta
 
 from feast import Entity, FeatureView, Field
-from feast.data_source import RequestSource
 from feast.feature_store import FeatureStore
 from feast.infra.offline_stores.file_source import FileSource
-from feast.on_demand_feature_view import on_demand_feature_view
-from feast.types import Float32, Int64
+from feast.types import Int64
 
 
 def test_apply_with_skip_validation_default(tmp_path):
     """Test that FeatureStore.apply() works with default skip_validation=False"""
-    
+
     # Create a temporary feature store
     fs = FeatureStore(
         config=f"""
@@ -36,15 +31,15 @@ def test_apply_with_skip_validation_default(tmp_path):
     path: {tmp_path / "online_store.db"}
 """
     )
-    
+
     # Create a basic feature view
     batch_source = FileSource(
         path=str(tmp_path / "data.parquet"),
         timestamp_field="event_timestamp",
     )
-    
+
     entity = Entity(name="test_entity", join_keys=["entity_id"])
-    
+
     fv = FeatureView(
         name="test_fv",
         entities=[entity],
@@ -55,21 +50,21 @@ def test_apply_with_skip_validation_default(tmp_path):
         source=batch_source,
         ttl=timedelta(days=1),
     )
-    
+
     # Apply with default skip_validation (should be False)
     fs.apply([entity, fv])
-    
+
     # Verify the feature view was applied
     feature_views = fs.list_feature_views()
     assert len(feature_views) == 1
     assert feature_views[0].name == "test_fv"
-    
+
     fs.teardown()
 
 
 def test_apply_with_skip_validation_true(tmp_path):
     """Test that FeatureStore.apply() accepts skip_validation=True parameter"""
-    
+
     # Create a temporary feature store
     fs = FeatureStore(
         config=f"""
@@ -81,15 +76,15 @@ def test_apply_with_skip_validation_true(tmp_path):
     path: {tmp_path / "online_store.db"}
 """
     )
-    
+
     # Create a basic feature view
     batch_source = FileSource(
         path=str(tmp_path / "data.parquet"),
         timestamp_field="event_timestamp",
     )
-    
+
     entity = Entity(name="test_entity", join_keys=["entity_id"])
-    
+
     fv = FeatureView(
         name="test_fv",
         entities=[entity],
@@ -100,23 +95,23 @@ def test_apply_with_skip_validation_true(tmp_path):
         source=batch_source,
         ttl=timedelta(days=1),
     )
-    
+
     # Apply with skip_validation=True
     # This should skip the _validate_all_feature_views() call
     fs.apply([entity, fv], skip_validation=True)
-    
+
     # Verify the feature view was applied
     feature_views = fs.list_feature_views()
     assert len(feature_views) == 1
     assert feature_views[0].name == "test_fv"
-    
+
     fs.teardown()
 
 
 def test_plan_with_skip_validation_parameter(tmp_path):
     """Test that FeatureStore.plan() accepts skip_validation parameter"""
     from feast.feature_store import RepoContents
-    
+
     # Create a temporary feature store
     fs = FeatureStore(
         config=f"""
@@ -128,15 +123,15 @@ def test_plan_with_skip_validation_parameter(tmp_path):
     path: {tmp_path / "online_store.db"}
 """
     )
-    
+
     # Create a basic feature view
     batch_source = FileSource(
         path=str(tmp_path / "data.parquet"),
         timestamp_field="event_timestamp",
     )
-    
+
     entity = Entity(name="test_entity", join_keys=["entity_id"])
-    
+
     fv = FeatureView(
         name="test_fv",
         entities=[entity],
@@ -147,7 +142,7 @@ def test_plan_with_skip_validation_parameter(tmp_path):
         source=batch_source,
         ttl=timedelta(days=1),
     )
-    
+
     # Create repo contents
     repo_contents = RepoContents(
         feature_views=[fv],
@@ -158,41 +153,40 @@ def test_plan_with_skip_validation_parameter(tmp_path):
         feature_services=[],
         permissions=[],
     )
-    
+
     # Plan with skip_validation=False (default)
     registry_diff, infra_diff, new_infra = fs.plan(repo_contents, skip_validation=False)
-    
+
     # Verify the diff shows the feature view will be added
     assert len(registry_diff.fv_to_add) == 1
-    
+
     # Plan with skip_validation=True
     registry_diff, infra_diff, new_infra = fs.plan(repo_contents, skip_validation=True)
-    
+
     # Verify the diff still works correctly
     assert len(registry_diff.fv_to_add) == 1
-    
+
     fs.teardown()
 
 
 def test_skip_validation_use_case_documentation():
     """
     Documentation test: This test documents the key use case for skip_validation.
-    
+
     The skip_validation flag is particularly important for On-Demand Feature Views (ODFVs)
     that use feature transformations. During the apply() process, ODFVs call infer_features()
     which internally uses _construct_random_input() to validate the transformation.
-    
+
     Sometimes this validation can be overly strict or fail for complex transformations.
     In such cases, users can use skip_validation=True to bypass this check.
-    
+
     Example use case from the issue:
     - User has an ODFV with a complex transformation
     - The _construct_random_input validation fails or is too restrictive
     - User can now call: fs.apply([odfv], skip_validation=True)
     - The ODFV is registered without going through the validation
-    
+
     Note: Users should be encouraged to report such cases on GitHub so the Feast team
     can improve the validation system.
     """
     pass  # This is a documentation test
-
