fix: Keep timestamp_field_type required in FeatureViewQueryContext

Jwrede · Jwrede · commit aed2012f863c · 2026-05-14T06:42:11.000Z
A default value on timestamp_field_type breaks the
SparkFeatureViewQueryContext subclass because its non-default fields
(min_date_partition, max_date_partition) would follow a field with a
default. Instead, keep it required and update the Spark test to pass it.

Signed-off-by: Jonathan Wrede &lt;wrede.jonathan00@gmail.com&gt;
diff --git a/sdk/python/feast/infra/offline_stores/offline_utils.py b/sdk/python/feast/infra/offline_stores/offline_utils.py
@@ -98,7 +98,7 @@ class FeatureViewQueryContext:
     date_partition_column: Optional[
         str
     ]  # this attribute is added because partition pruning affects Athena's query performance.
-    timestamp_field_type: Optional[str] = None
+    timestamp_field_type: Optional[str]
 
 
 def get_feature_view_query_context(
diff --git a/sdk/python/tests/unit/infra/offline_stores/contrib/spark_offline_store/test_spark_bfv_compute_on_read.py b/sdk/python/tests/unit/infra/offline_stores/contrib/spark_offline_store/test_spark_bfv_compute_on_read.py
@@ -52,6 +52,7 @@ def base_query_context():
         min_event_timestamp="2023-01-01T00:00:00",
         max_event_timestamp="2024-01-01T00:00:00",
         date_partition_column=None,
+        timestamp_field_type=None,
     )
 
 

Original file line number	Diff line number	Diff line change
`@@ -52,6 +52,7 @@ def base_query_context():`
`52`	`52`	`min_event_timestamp="2023-01-01T00:00:00",`
`53`	`53`	`max_event_timestamp="2024-01-01T00:00:00",`
`54`	`54`	`date_partition_column=None,`
	`55`	`+ timestamp_field_type=None,`
`55`	`56`	`)`
`56`	`57`
`57`	`58`