feast-dev
diff --git a/‎go/feast/basefeatureview.go‎
Lines changed: 4 additions & 4 deletions b/‎go/feast/basefeatureview.go‎
Lines changed: 4 additions & 4 deletions
diff --git a/‎go/feast/connector.go‎
Lines changed: 2 additions & 59 deletions b/‎go/feast/connector.go‎
Lines changed: 2 additions & 59 deletions
diff --git a/‎go/feast/feature_store_integration_test.go‎
Lines changed: 0 additions & 216 deletions b/‎go/feast/feature_store_integration_test.go‎
Lines changed: 0 additions & 216 deletions
@@ -25,17 +25,17 @@ func NewBaseFeatureView(name string, featureProtos []*core.FeatureSpecV2) *BaseF
 
 func (fv *BaseFeatureView) withProjection(projection *FeatureViewProjection) (*BaseFeatureView, error) {
 	if projection.name != fv.name {
-		return nil, errors.New(fmt.Sprintf("The projection for the %s FeatureView cannot be applied because it differs in name. " +
-									"The projection is named %s and the name indicates which " +
-									"FeatureView the projection is for.", fv.name, projection.name))
+		return nil, errors.New(fmt.Sprintf(	"The projection for the %s FeatureView cannot be applied because it differs in name. " +
+											"The projection is named %s and the name indicates which " +
+											"FeatureView the projection is for.", fv.name, projection.name))
 	}
 	features := make(map[string]bool)
 	for _, feature := range fv.features {
 		features[feature.name] = true
 	}
 	for _, feature := range projection.features {
 		if _, ok := features[feature.name]; !ok {
-			return nil, errors.New(fmt.Sprintf("The projection for %s cannot be applied because it contains %s which the " +
+			return nil, errors.New(fmt.Sprintf(	"The projection for %s cannot be applied because it contains %s which the " +
 												"FeatureView doesn't have.", projection.name, feature.name))
 		}
 	}
 
@@ -3,12 +3,6 @@ package feast
 import (
 	"errors"
 	"fmt"
-	// "os"
-	"os/exec"
-	"github.com/hashicorp/go-plugin"
-	// "github.com/hashicorp/go-hclog"
-	"log"
-	"io/ioutil"
 )
 
 func getOnlineStore(config *RepoConfig) (OnlineStore, error) {
@@ -20,57 +14,6 @@ func getOnlineStore(config *RepoConfig) (OnlineStore, error) {
 		onlineStore, err := NewRedisOnlineStore(config.Project, config.OnlineStore)
 		return onlineStore, err
 	} else {
-		// TODO(willem): Python connectors here
-		KV_PLUGIN := config.OnlineStore["KV_PLUGIN"].(string)
-		return connectorClient(KV_PLUGIN)
+		return nil, errors.New("Only Redis is supported as an online store for now")
 	}
-}
-
-func connectorClient(KV_PLUGIN string) (OnlineStore, error) {
-	// We don't want to see the plugin logs.
-	log.SetOutput(ioutil.Discard)
-
-	// We're a host. Start by launching the plugin process.
-	cmd := exec.Command("sh", "-c", KV_PLUGIN )
-
-	// logger := hclog.New(&hclog.LoggerOptions{
-	// 	Name:   "plugin",
-	// 	Output: os.Stdout,
-	// 	Level:  hclog.Debug,
-	// })
-
-	client := plugin.NewClient(&plugin.ClientConfig{
-		HandshakeConfig: Handshake,
-		Plugins:         PluginMap,
-		Cmd:             cmd,
-		AllowedProtocols: []plugin.Protocol{
-			plugin.ProtocolGRPC},
-		// Logger:          logger,
-	})
-	
-	// Connect via RPC
-	rpcClient, err := client.Client()
-	if err != nil {
-		return nil, err
-	}
-	// Request the plugin
-	raw, err := rpcClient.Dispense("onlinestore_grpc")
-	if err != nil {
-		return nil, err
-	}
-
-	// We should have a OnlineStore now! This feels like a normal interface
-	// implementation but is in fact over an RPC connection.
-	if onlineStore, ok := raw.(OnlineStore); !ok {
-		return nil, errors.New("Error creating a Connector OnlineStore")
-	} else {
-		grpcClient, ok := onlineStore.(*GRPCClient)
-		if !ok {
-			return nil, errors.New("Connector is not a *connector.GrpcClient")
-		}
-		grpcClient.destructor = func() {
-			client.Kill()
-		}
-		return onlineStore, nil
-	}
-}
+}
Original file line number	Diff line number	Diff line change
`@@ -25,17 +25,17 @@ func NewBaseFeatureView(name string, featureProtos []core.FeatureSpecV2) BaseF`
`25`	`25`
`26`	`26`	`func (fv BaseFeatureView) withProjection(projection FeatureViewProjection) (*BaseFeatureView, error) {`
`27`	`27`	`if projection.name != fv.name {`
`28`		`- return nil, errors.New(fmt.Sprintf("The projection for the %s FeatureView cannot be applied because it differs in name. " +`
`29`		`- "The projection is named %s and the name indicates which " +`
`30`		`- "FeatureView the projection is for.", fv.name, projection.name))`
	`28`	`+ return nil, errors.New(fmt.Sprintf( "The projection for the %s FeatureView cannot be applied because it differs in name. " +`
	`29`	`+ "The projection is named %s and the name indicates which " +`
	`30`	`+ "FeatureView the projection is for.", fv.name, projection.name))`
`31`	`31`	`}`
`32`	`32`	`features := make(map[string]bool)`
`33`	`33`	`for _, feature := range fv.features {`
`34`	`34`	`features[feature.name] = true`
`35`	`35`	`}`
`36`	`36`	`for _, feature := range projection.features {`
`37`	`37`	`if _, ok := features[feature.name]; !ok {`
`38`		`- return nil, errors.New(fmt.Sprintf("The projection for %s cannot be applied because it contains %s which the " +`
	`38`	`+ return nil, errors.New(fmt.Sprintf( "The projection for %s cannot be applied because it contains %s which the " +`
`39`	`39`	`"FeatureView doesn't have.", projection.name, feature.name))`
`40`	`40`	`}`
`41`	`41`	`}`