chore: fixed test cases

jatin5251 · jatin5251 · commit 99b5ca722860 · 2026-02-03T00:52:00.000+01:00
Signed-off-by: Jatin Kumar &lt;jatink.5251@gmail.com&gt;
diff --git a/infra/feast-operator/internal/controller/featurestore_controller_test.go b/infra/feast-operator/internal/controller/featurestore_controller_test.go
@@ -1189,7 +1189,7 @@ var _ = Describe("FeatureStore Controller", func() {
 			Expect(apimeta.FindStatusCondition(resource.Status.Conditions, feastdevv1.RegistryReadyType)).To(BeNil())
 			Expect(apimeta.IsStatusConditionTrue(resource.Status.Conditions, feastdevv1.ReadyType)).To(BeFalse())
 			Expect(apimeta.IsStatusConditionTrue(resource.Status.Conditions, feastdevv1.OnlineStoreReadyType)).To(BeTrue())
-			Expect(apimeta.IsStatusConditionTrue(resource.Status.Conditions, feastdevv1.OfflineStoreReadyType)).To(BeTrue())
+			Expect(apimeta.FindStatusCondition(resource.Status.Conditions, feastdevv1.OfflineStoreReadyType)).To(BeNil())
 			Expect(resource.Status.Applied.Services.Registry.Remote.FeastRef.Name).To(Equal(referencedRegistry.Name))
 			cond = apimeta.FindStatusCondition(resource.Status.Conditions, feastdevv1.ReadyType)
 			Expect(cond).NotTo(BeNil())
diff --git a/infra/feast-operator/internal/controller/services/services_test.go b/infra/feast-operator/internal/controller/services/services_test.go
@@ -42,12 +42,10 @@ func (feast *FeastServices) refreshFeatureStore(ctx context.Context, key types.N
 }
 
 func applySpecToStatus(fs *feastdevv1.FeatureStore) {
-	if fs.Status.Applied.Services == nil && fs.Spec.Services != nil {
+	if fs.Spec.Services != nil {
 		fs.Status.Applied.Services = fs.Spec.Services.DeepCopy()
 	}
-	if len(fs.Status.Applied.FeastProject) == 0 {
-		fs.Status.Applied.FeastProject = fs.Spec.FeastProject
-	}
+	fs.Status.Applied.FeastProject = fs.Spec.FeastProject
 	Expect(k8sClient.Status().Update(context.Background(), fs)).To(Succeed())
 }
 

Original file line number	Diff line number	Diff line change
`@@ -42,12 +42,10 @@ func (feast *FeastServices) refreshFeatureStore(ctx context.Context, key types.N`
`42`	`42`	`}`
`43`	`43`
`44`	`44`	`func applySpecToStatus(fs *feastdevv1.FeatureStore) {`
`45`		`- if fs.Status.Applied.Services == nil && fs.Spec.Services != nil {`
	`45`	`+ if fs.Spec.Services != nil {`
`46`	`46`	`fs.Status.Applied.Services = fs.Spec.Services.DeepCopy()`
`47`	`47`	`}`
`48`		`- if len(fs.Status.Applied.FeastProject) == 0 {`
`49`		`- fs.Status.Applied.FeastProject = fs.Spec.FeastProject`
`50`		`- }`
	`48`	`+ fs.Status.Applied.FeastProject = fs.Spec.FeastProject`
`51`	`49`	`Expect(k8sClient.Status().Update(context.Background(), fs)).To(Succeed())`
`52`	`50`	`}`
`53`	`51`