fix | trino_offline_store: Timestamp formatting and lakehouse-type connector

soliverr · soliverr · commit 818a0cd17575 · 2026-01-13T13:16:20.000+01:00
diff --git a/sdk/python/feast/infra/offline_stores/contrib/trino_offline_store/connectors/upload.py b/sdk/python/feast/infra/offline_stores/contrib/trino_offline_store/connectors/upload.py
@@ -56,6 +56,7 @@
     "oracle",
     "redshift",
     "memsql",
+    "lakehouse",
 }
 
 CREATE_SCHEMA_QUERY_TEMPLATE = """
diff --git a/sdk/python/feast/infra/offline_stores/contrib/trino_offline_store/trino.py b/sdk/python/feast/infra/offline_stores/contrib/trino_offline_store/trino.py
@@ -424,11 +424,11 @@ def pull_all_from_table_or_query(
         )
 
         timestamp_filter = get_timestamp_filter_sql(
-            start_date, end_date, timestamp_field, quote_fields=False
+            start_date, end_date, timestamp_field, quote_fields=False, cast_style='timestamp', date_time_separator=' '
         )
         query = f"""
             SELECT {field_string}
-            FROM {from_expression}
+            FROM ( {from_expression} )
             WHERE {timestamp_filter}
         """
         return TrinoRetrievalJob(

Original file line number	Diff line number	Diff line change
`@@ -56,6 +56,7 @@`
`56`	`56`	`"oracle",`
`57`	`57`	`"redshift",`
`58`	`58`	`"memsql",`
	`59`	`+ "lakehouse",`
`59`	`60`	`}`
`60`	`61`
`61`	`62`	`CREATE_SCHEMA_QUERY_TEMPLATE = """`
Original file line number	Diff line number	Diff line change
`@@ -424,11 +424,11 @@ def pull_all_from_table_or_query(`
`424`	`424`	`)`
`425`	`425`
`426`	`426`	`timestamp_filter = get_timestamp_filter_sql(`
`427`		`- start_date, end_date, timestamp_field, quote_fields=False`
	`427`	`+ start_date, end_date, timestamp_field, quote_fields=False, cast_style='timestamp', date_time_separator=' '`
`428`	`428`	`)`
`429`	`429`	`query = f"""`
`430`	`430`	`SELECT {field_string}`
`431`		`- FROM {from_expression}`
	`431`	`+ FROM ( {from_expression} )`
`432`	`432`	`WHERE {timestamp_filter}`
`433`	`433`	`"""`
`434`	`434`	`return TrinoRetrievalJob(`