Skip to content

Commit 7ba4684

Browse files
chore: updated snowflake test to be more explicit about post apply entity_column return value
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
1 parent 9646f03 commit 7ba4684

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

sdk/python/tests/integration/materialization/test_snowflake.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
from feast import Field
77
from feast.entity import Entity
8-
from feast.feature_view import FeatureView
8+
from feast.feature_view import DUMMY_ENTITY_FIELD, FeatureView
99
from feast.types import Array, Bool, Bytes, Float64, Int32, Int64, String, UnixTimestamp
1010
from feast.utils import _utc_now
1111
from tests.data.data_creator import create_basic_driver_dataset
@@ -189,7 +189,7 @@ def test_snowflake_materialization_consistency_internal_with_lists(
189189
snowflake_environment.data_source_creator.teardown()
190190

191191

192-
@pytest.mark.integration
192+
# @pytest.mark.integration
193193
def test_snowflake_materialization_entityless_fv():
194194
snowflake_config = IntegrationTestRepoConfig(
195195
online_store=SNOWFLAKE_ONLINE_CONFIG,
@@ -225,7 +225,7 @@ def test_snowflake_materialization_entityless_fv():
225225

226226
try:
227227
fs.apply([overall_stats_fv, driver])
228-
assert overall_stats_fv.entity_columns != []
228+
assert overall_stats_fv.entity_columns == [DUMMY_ENTITY_FIELD]
229229

230230
# materialization is run in two steps and
231231
# we use timestamp from generated dataframe as a split point

0 commit comments

Comments
 (0)