Skip to content

Commit 75dcc2d

Browse files
committed
test: Added test to verify registry with REST API enabled
Signed-off-by: ntkathole <nikhilkathole2683@gmail.com>
1 parent b9f7450 commit 75dcc2d

File tree

1 file changed

+45
-0
lines changed

1 file changed

+45
-0
lines changed

infra/feast-operator/internal/controller/featurestore_controller_test.go

Lines changed: 45 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1213,6 +1213,51 @@ var _ = Describe("FeatureStore Controller", func() {
12131213
Expect(cond.Message).To(Equal("Error: Remote feast registry of referenced FeatureStore '" + referencedRegistry.Name + "' is not ready"))
12141214
})
12151215

1216+
It("should handle local registry with REST API enabled", func() {
1217+
By("By properly setting RestAPI registry in status")
1218+
1219+
controllerReconciler := &FeatureStoreReconciler{
1220+
Client: k8sClient,
1221+
Scheme: k8sClient.Scheme(),
1222+
}
1223+
1224+
name := "rest-registry-featurestore"
1225+
namespace := "default"
1226+
nsName := types.NamespacedName{
1227+
Name: name,
1228+
Namespace: namespace,
1229+
}
1230+
1231+
resource := &feastdevv1alpha1.FeatureStore{
1232+
ObjectMeta: metav1.ObjectMeta{
1233+
Name: name,
1234+
Namespace: namespace,
1235+
},
1236+
Spec: feastdevv1alpha1.FeatureStoreSpec{
1237+
FeastProject: feastProject,
1238+
Services: &feastdevv1alpha1.FeatureStoreServices{
1239+
Registry: &feastdevv1alpha1.Registry{
1240+
Local: &feastdevv1alpha1.LocalRegistryConfig{
1241+
Server: &feastdevv1alpha1.RegistryServerConfigs{
1242+
RestAPI: true,
1243+
},
1244+
},
1245+
},
1246+
},
1247+
},
1248+
}
1249+
resource.SetGroupVersionKind(feastdevv1alpha1.GroupVersion.WithKind("FeatureStore"))
1250+
err := k8sClient.Create(ctx, resource)
1251+
Expect(err).NotTo(HaveOccurred())
1252+
_, err = controllerReconciler.Reconcile(ctx, reconcile.Request{
1253+
NamespacedName: nsName,
1254+
})
1255+
Expect(err).NotTo(HaveOccurred())
1256+
err = k8sClient.Get(ctx, nsName, resource)
1257+
Expect(err).NotTo(HaveOccurred())
1258+
Expect(resource.Status.Applied.Services.Registry.Local.Server.RestAPI).To(BeTrue())
1259+
})
1260+
12161261
It("should error on reconcile", func() {
12171262
By("Trying to set the controller OwnerRef of a Deployment that already has a controller")
12181263
controllerReconciler := &FeatureStoreReconciler{

0 commit comments

Comments
 (0)