Skip to content

Commit 702eebf

Browse files
HaoXuAIHaoXuAI
authored
feat!: Refactor online stores by removing the contrib directory. (Breaking imports) (#4731)
* feat: Refactor online store by removing the contrib directory Signed-off-by: HaoXuAI <sduxuhao@gmail.com> * feat: Refactor online store by removing the contrib directory Signed-off-by: HaoXuAI <sduxuhao@gmail.com> * feat: Refactor online store by removing the contrib directory Signed-off-by: HaoXuAI <sduxuhao@gmail.com> * feat: Refactor online store by removing the contrib directory Signed-off-by: HaoXuAI <sduxuhao@gmail.com> * fix legacy mapping Signed-off-by: HaoXuAI <sduxuhao@gmail.com> * fix legacy mapping Signed-off-by: HaoXuAI <sduxuhao@gmail.com> --------- Signed-off-by: HaoXuAI <sduxuhao@gmail.com>
1 parent 0150278 commit 702eebf

File tree

55 files changed

+95
-82
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

55 files changed

+95
-82
lines changed

‎Makefile‎

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -223,7 +223,7 @@ test-python-universal-postgres-offline:
223223

224224
test-python-universal-postgres-online:
225225
PYTHONPATH='.' \
226-
FULL_REPO_CONFIGS_MODULE=sdk.python.feast.infra.online_stores.contrib.postgres_repo_configuration \
226+
FULL_REPO_CONFIGS_MODULE=sdk.python.feast.infra.online_stores.postgres_online_store.postgres_repo_configuration \
227227
PYTEST_PLUGINS=sdk.python.tests.integration.feature_repos.universal.online_store.postgres \
228228
python -m pytest -n 8 --integration \
229229
-k "not test_universal_cli and \
@@ -242,7 +242,7 @@ test-python-universal-postgres-online:
242242

243243
test-python-universal-pgvector-online:
244244
PYTHONPATH='.' \
245-
FULL_REPO_CONFIGS_MODULE=sdk.python.feast.infra.online_stores.contrib.pgvector_repo_configuration \
245+
FULL_REPO_CONFIGS_MODULE=sdk.python.feast.infra.online_stores.pgvector_repo_configuration \
246246
PYTEST_PLUGINS=sdk.python.tests.integration.feature_repos.universal.online_store.postgres \
247247
python -m pytest -n 8 --integration \
248248
-k "not test_universal_cli and \
@@ -261,7 +261,7 @@ test-python-universal-postgres-online:
261261

262262
test-python-universal-mysql-online:
263263
PYTHONPATH='.' \
264-
FULL_REPO_CONFIGS_MODULE=sdk.python.feast.infra.online_stores.contrib.mysql_repo_configuration \
264+
FULL_REPO_CONFIGS_MODULE=sdk.python.feast.infra.online_stores.mysql_online_store.mysql_repo_configuration \
265265
PYTEST_PLUGINS=sdk.python.tests.integration.feature_repos.universal.online_store.mysql \
266266
python -m pytest -n 8 --integration \
267267
-k "not test_universal_cli and \
@@ -280,14 +280,14 @@ test-python-universal-postgres-online:
280280

281281
test-python-universal-cassandra:
282282
PYTHONPATH='.' \
283-
FULL_REPO_CONFIGS_MODULE=sdk.python.feast.infra.online_stores.contrib.cassandra_repo_configuration \
283+
FULL_REPO_CONFIGS_MODULE=sdk.python.feast.infra.online_stores.cassandra_online_store.cassandra_repo_configuration \
284284
PYTEST_PLUGINS=sdk.python.tests.integration.feature_repos.universal.online_store.cassandra \
285285
python -m pytest -x --integration \
286286
sdk/python/tests
287287

288288
test-python-universal-hazelcast:
289289
PYTHONPATH='.' \
290-
FULL_REPO_CONFIGS_MODULE=sdk.python.feast.infra.online_stores.contrib.hazelcast_repo_configuration \
290+
FULL_REPO_CONFIGS_MODULE=sdk.python.feast.infra.online_stores.hazelcast_online_store.hazelcast_repo_configuration \
291291
PYTEST_PLUGINS=sdk.python.tests.integration.feature_repos.universal.online_store.hazelcast \
292292
python -m pytest -n 8 --integration \
293293
-k "not test_universal_cli and \
@@ -306,7 +306,7 @@ test-python-universal-hazelcast:
306306

307307
test-python-universal-cassandra-no-cloud-providers:
308308
PYTHONPATH='.' \
309-
FULL_REPO_CONFIGS_MODULE=sdk.python.feast.infra.online_stores.contrib.cassandra_repo_configuration \
309+
FULL_REPO_CONFIGS_MODULE=sdk.python.feast.infra.online_stores.cassandra_online_store.cassandra_repo_configuration \
310310
PYTEST_PLUGINS=sdk.python.tests.integration.feature_repos.universal.online_store.cassandra \
311311
python -m pytest -x --integration \
312312
-k "not test_lambda_materialization_consistency and \
@@ -323,7 +323,7 @@ test-python-universal-cassandra-no-cloud-providers:
323323

324324
test-python-universal-elasticsearch-online:
325325
PYTHONPATH='.' \
326-
FULL_REPO_CONFIGS_MODULE=sdk.python.feast.infra.online_stores.contrib.elasticsearch_repo_configuration \
326+
FULL_REPO_CONFIGS_MODULE=sdk.python.feast.infra.online_stores.elasticsearch_online_store.elasticsearch_repo_configuration \
327327
PYTEST_PLUGINS=sdk.python.tests.integration.feature_repos.universal.online_store.elasticsearch \
328328
python -m pytest -n 8 --integration \
329329
-k "not test_universal_cli and \
@@ -342,7 +342,7 @@ test-python-universal-cassandra-no-cloud-providers:
342342

343343
test-python-universal-singlestore-online:
344344
PYTHONPATH='.' \
345-
FULL_REPO_CONFIGS_MODULE=sdk.python.feast.infra.online_stores.contrib.singlestore_repo_configuration \
345+
FULL_REPO_CONFIGS_MODULE=sdk.python.feast.infra.online_stores.singlestore_repo_configuration \
346346
PYTEST_PLUGINS=sdk.python.tests.integration.feature_repos.universal.online_store.singlestore \
347347
python -m pytest -n 8 --integration \
348348
-k "not test_universal_cli and \
@@ -353,7 +353,7 @@ test-python-universal-singlestore-online:
353353

354354
test-python-universal-qdrant-online:
355355
PYTHONPATH='.' \
356-
FULL_REPO_CONFIGS_MODULE=sdk.python.feast.infra.online_stores.contrib.qdrant_repo_configuration \
356+
FULL_REPO_CONFIGS_MODULE=sdk.python.feast.infra.online_stores.qdrant_online_store.qdrant_repo_configuration \
357357
PYTEST_PLUGINS=sdk.python.tests.integration.feature_repos.universal.online_store.qdrant \
358358
python -m pytest -n 8 --integration \
359359
-k "test_retrieve_online_documents" \

‎docs/SUMMARY.md‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -105,13 +105,13 @@
105105
* [DynamoDB](reference/online-stores/dynamodb.md)
106106
* [Bigtable](reference/online-stores/bigtable.md)
107107
* [Remote](reference/online-stores/remote.md)
108-
* [PostgreSQL (contrib)](reference/online-stores/postgres.md)
109-
* [Cassandra + Astra DB (contrib)](reference/online-stores/cassandra.md)
110-
* [Couchbase (contrib)](reference/online-stores/couchbase.md)
111-
* [MySQL (contrib)](reference/online-stores/mysql.md)
112-
* [Hazelcast (contrib)](reference/online-stores/hazelcast.md)
113-
* [ScyllaDB (contrib)](reference/online-stores/scylladb.md)
114-
* [SingleStore (contrib)](reference/online-stores/singlestore.md)
108+
* [PostgreSQL](reference/online-stores/postgres.md)
109+
* [Cassandra + Astra DB](reference/online-stores/cassandra.md)
110+
* [Couchbase](reference/online-stores/couchbase.md)
111+
* [MySQL](reference/online-stores/mysql.md)
112+
* [Hazelcast](reference/online-stores/hazelcast.md)
113+
* [ScyllaDB](reference/online-stores/scylladb.md)
114+
* [SingleStore](reference/online-stores/singlestore.md)
115115
* [Registries](reference/registries/README.md)
116116
* [Local](reference/registries/local.md)
117117
* [S3](reference/registries/s3.md)

‎docs/how-to-guides/customizing-feast/adding-support-for-a-new-online-store.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -372,7 +372,7 @@ class RedisOnlineStoreCreator(OnlineStoreCreator):
372372
```Makefile
373373
test-python-universal-cassandra:
374374
PYTHONPATH='.' \
375-
FULL_REPO_CONFIGS_MODULE=sdk.python.feast.infra.online_stores.contrib.cassandra_repo_configuration \
375+
FULL_REPO_CONFIGS_MODULE=sdk.python.feast.infra.online_stores.cassandra_online_store.cassandra_repo_configuration \
376376
PYTEST_PLUGINS=sdk.python.tests.integration.feature_repos.universal.online_store.cassandra \
377377
IS_TEST=True \
378378
python -m pytest -x --integration \

‎docs/reference/online-stores/cassandra.md‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# Cassandra + Astra DB online store (contrib)
1+
# Cassandra + Astra DB online store
22

33
## Description
44

@@ -59,7 +59,7 @@ online_store:
5959
```
6060
{% endcode %}
6161
62-
The full set of configuration options is available in [CassandraOnlineStoreConfig](https://rtd.feast.dev/en/master/#feast.infra.online_stores.contrib.cassandra_online_store.cassandra_online_store.CassandraOnlineStoreConfig).
62+
The full set of configuration options is available in [CassandraOnlineStoreConfig](https://rtd.feast.dev/en/master/#feast.infra.online_stores.cassandra_online_store.cassandra_online_store.CassandraOnlineStoreConfig).
6363
For a full explanation of configuration options please look at file
6464
`sdk/python/feast/infra/online_stores/contrib/cassandra_online_store/README.md`.
6565

‎docs/reference/online-stores/elasticsearch.md‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# ElasticSearch online store (contrib)
1+
# ElasticSearch online store
22

33
## Description
44

@@ -26,7 +26,7 @@ online_store:
2626
```
2727
{% endcode %}
2828
29-
The full set of configuration options is available in [ElasticsearchOnlineStoreConfig](https://rtd.feast.dev/en/master/#feast.infra.online_stores.contrib.elasticsearch.ElasticsearchOnlineStoreConfig).
29+
The full set of configuration options is available in [ElasticsearchOnlineStoreConfig](https://rtd.feast.dev/en/master/#feast.infra.online_stores.elasticsearch_online_store.ElasticsearchOnlineStoreConfig).
3030
3131
## Functionality Matrix
3232

‎docs/reference/online-stores/mysql.md‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# MySQL online store (contrib)
1+
# MySQL online store
22

33
## Description
44

@@ -26,7 +26,7 @@ online_store:
2626
```
2727
{% endcode %}
2828
29-
The full set of configuration options is available in [MySQLOnlineStoreConfig](https://rtd.feast.dev/en/master/#feast.infra.online_stores.contrib.mysql.MySQLOnlineStoreConfig).
29+
The full set of configuration options is available in [MySQLOnlineStoreConfig](https://rtd.feast.dev/en/master/#feast.infra.online_stores.mysql_online_store.MySQLOnlineStoreConfig).
3030
3131
## Functionality Matrix
3232

‎docs/reference/online-stores/postgres.md‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# PostgreSQL online store (contrib)
1+
# PostgreSQL online store
22

33
## Description
44

@@ -35,7 +35,7 @@ online_store:
3535
```
3636
{% endcode %}
3737
38-
The full set of configuration options is available in [PostgreSQLOnlineStoreConfig](https://rtd.feast.dev/en/master/#feast.infra.online_stores.contrib.postgres.PostgreSQLOnlineStoreConfig).
38+
The full set of configuration options is available in [PostgreSQLOnlineStoreConfig](https://rtd.feast.dev/en/master/#feast.infra.online_stores.postgres_online_store.PostgreSQLOnlineStoreConfig).
3939
4040
## Functionality Matrix
4141
@@ -79,7 +79,7 @@ For the Retrieval Augmented Generation (RAG) use-case, you have to embed the qu
7979
{% code title="python" %}
8080
```python
8181
from feast import FeatureStore
82-
from feast.infra.online_stores.postgres import retrieve_online_documents
82+
from feast.infra.online_stores.postgres_online_store import retrieve_online_documents
8383
8484
feature_store = FeatureStore(repo_path=".")
8585

‎docs/reference/online-stores/qdrant.md‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# Qdrant online store (contrib)
1+
# Qdrant online store
22

33
## Description
44

@@ -26,7 +26,7 @@ online_store:
2626
2727
{% endcode %}
2828
29-
The full set of configuration options is available in [QdrantOnlineStoreConfig](https://rtd.feast.dev/en/master/#feast.infra.online_stores.contrib.qdrant.QdrantOnlineStoreConfig).
29+
The full set of configuration options is available in [QdrantOnlineStoreConfig](https://rtd.feast.dev/en/master/#feast.infra.online_stores.qdrant_online_store.QdrantOnlineStoreConfig).
3030
3131
## Functionality Matrix
3232

‎docs/reference/online-stores/scylladb.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ online_store:
5555
{% endcode %}
5656
5757
58-
The full set of configuration options is available in [CassandraOnlineStoreConfig](https://rtd.feast.dev/en/master/#feast.infra.online_stores.contrib.cassandra_online_store.cassandra_online_store.CassandraOnlineStoreConfig).
58+
The full set of configuration options is available in [CassandraOnlineStoreConfig](https://rtd.feast.dev/en/master/#feast.infra.online_stores.cassandra_online_store.cassandra_online_store.CassandraOnlineStoreConfig).
5959
For a full explanation of configuration options please look at file
6060
`sdk/python/feast/infra/online_stores/contrib/cassandra_online_store/README.md`.
6161

‎docs/reference/online-stores/singlestore.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# SingleStore online store (contrib)
1+
# SingleStore online store
22

33
## Description
44

0 commit comments

Comments
 (0)