Skip to content

Commit 5ccd4ea

Browse files
author
hao-xu5
committed
add aggregation to odfv
Signed-off-by: hao-xu5 <hxu44@apple.com>
1 parent 398dbfa commit 5ccd4ea

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

sdk/python/feast/utils.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -672,7 +672,7 @@ def _augment_response_with_on_demand_transforms(
672672
for odfv_name, _feature_refs in odfv_feature_refs.items():
673673
odfv = requested_odfv_map[odfv_name]
674674
if not odfv.write_to_online_store:
675-
# Apply aggregations BEFORE transformation if defined
675+
# Apply aggregations if configured.
676676
if odfv.aggregations:
677677
if odfv.mode == "python":
678678
if initial_response_dict is None:
@@ -694,7 +694,7 @@ def _augment_response_with_on_demand_transforms(
694694
)
695695

696696
# Apply transformation
697-
if odfv.mode == "python":
697+
elif odfv.mode == "python":
698698
if initial_response_dict is None:
699699
initial_response_dict = initial_response.to_dict()
700700
transformed_features_dict: Dict[str, List[Any]] = odfv.transform_dict(

0 commit comments

Comments
 (0)