fix

franciscojavierarceo · franciscojavierarceo · commit 50e536a13caa · 2026-01-05T11:26:58.000-05:00
Signed-off-by: Francisco Javier Arceo &lt;farceo@redhat.com&gt;
diff --git a/sdk/python/feast/feature_store.py b/sdk/python/feast/feature_store.py
@@ -1019,7 +1019,7 @@ def apply(
 
                 # Create ODFV with same transformation logic and correct mode
                 # Include both FeatureViews and RequestSources in sources
-                sources_list = list(fv.source_views or [])
+                sources_list: List[Union[FeatureView, RequestSource]] = list(fv.source_views or [])
                 if hasattr(fv, "source_request_sources") and fv.source_request_sources:
                     sources_list.extend(fv.source_request_sources.values())
 
@@ -1293,9 +1293,9 @@ def get_historical_features(
 
         # Handle FeatureViews with feature_transformation for historical retrieval
         # These are supported by extracting their source views and applying transformations later
-        regular_feature_views = []
-        unified_transformation_views = []
-        source_feature_views = []
+        regular_feature_views: List[Union[FeatureView, OnDemandFeatureView]] = []
+        unified_transformation_views: List[Tuple[Union[FeatureView, OnDemandFeatureView], List[str]]] = []
+        source_feature_views: List[Union[FeatureView, OnDemandFeatureView]] = []
 
         # Separate FeatureViews with transformations from regular ones
         for fv, features_list in fvs:
diff --git a/sdk/python/feast/utils.py b/sdk/python/feast/utils.py
@@ -529,7 +529,8 @@ def _group_feature_refs(
             # Redirect if:
             # 1. Feature exists in original view but online serving is disabled, OR
             # 2. Feature doesn't exist in original view at all
-            if feat_name in feature_names_in_original and not original_view.online:
+            if (feat_name in feature_names_in_original
+                and hasattr(original_view, 'online') and not original_view.online):
                 should_redirect = True
             elif feat_name not in feature_names_in_original:
                 should_redirect = True
