CR comments

achals · achals · commit 481b8ddf2fb5 · 2022-03-08T12:16:37.000-08:00
Signed-off-by: Achal Shah &lt;achals@gmail.com&gt;
diff --git a/.github/workflows/linter.yml b/.github/workflows/linter.yml
@@ -19,7 +19,7 @@ jobs:
         id: setup-go
         uses: actions/setup-go@v2
         with:
-          go-version: "1.17.0"
+          go-version: 1.17.7
       - name: Upgrade pip version
         run: |
           pip install --upgrade "pip>=21.3.1"
diff --git a/Makefile b/Makefile
@@ -130,7 +130,7 @@ install-go-ci-dependencies:
 	go install google.golang.org/grpc/cmd/protoc-gen-go-grpc@v1.1.0
 
 compile-protos-go: install-go-ci-dependencies
-	pip install -e "sdk/python[ci]"
+	pip install grpcio-tools==1.34.0
 	python sdk/python/setup.py build_go_protos
 
 compile-go-feature-server: compile-protos-go
@@ -141,7 +141,7 @@ test-go: install-go-ci-dependencies
 	go test ./...
 
 format-go:
-	gofmt -s -w go/**/**/*.go
+	gofmt -s -w go/
 
 lint-go: compile-protos-go
 	go vet ./go/internal/feast ./go/cmd/goserver
diff --git a/sdk/python/setup.py b/sdk/python/setup.py
@@ -306,7 +306,7 @@ def _generate_go_protos(self, path: str):
             print(f"Stderr: {e.stderr}")
             print(f"Stdout: {e.stdout}")
 
-    def _compile_go_feaure_server(self):
+    def _compile_go_feature_server(self):
         print("Compile go feature server")
         subprocess.check_call(["go",
                                "build",
@@ -321,7 +321,7 @@ def run(self):
         go_dir.mkdir(exist_ok=True)
         for sub_folder in self.sub_folders:
             self._generate_go_protos(f"feast/{sub_folder}/*.proto")
-        self._compile_go_feaure_server()
+        self._compile_go_feature_server()
 
 
 class BuildCommand(build_py):
