Clean up document endpoints

franciscojavierarceo · claude · franciscojavierarceo · commit 4018e7b0c398 · 2026-01-28T12:30:34.000-05:00
Co-Authored-By: Claude Sonnet 4 &lt;noreply@anthropic.com&gt;
diff --git a/sdk/python/feast/feature_server.py b/sdk/python/feast/feature_server.py
@@ -129,15 +129,6 @@ class ChatRequest(BaseModel):
     messages: List[ChatMessage]
 
 
-class ReadDocumentRequest(BaseModel):
-    file_path: str
-
-
-class SaveDocumentRequest(BaseModel):
-    file_path: str
-    data: dict
-
-
 async def _get_features(
     request: Union[GetOnlineFeaturesRequest, GetOnlineDocumentsRequest],
     store: "feast.FeatureStore",
@@ -542,42 +533,6 @@ async def chat(request: ChatRequest):
         # For now, just return dummy text
         return {"response": "This is a dummy response from the Feast feature server."}
 
-    @app.post("/read-document", dependencies=[Depends(inject_user_details)])
-    async def read_document_endpoint(request: ReadDocumentRequest):
-        try:
-            import os
-
-            if not os.path.exists(request.file_path):
-                return {"error": f"File not found: {request.file_path}"}
-
-            with open(request.file_path, "r", encoding="utf-8") as file:
-                content = file.read()
-
-            return {"content": content, "file_path": request.file_path}
-        except Exception as e:
-            return {"error": str(e)}
-
-    @app.post("/save-document", dependencies=[Depends(inject_user_details)])
-    async def save_document_endpoint(request: SaveDocumentRequest):
-        try:
-            import json
-            import os
-            from pathlib import Path
-
-            file_path = Path(request.file_path).resolve()
-            if not str(file_path).startswith(os.getcwd()):
-                return {"error": "Invalid file path"}
-
-            base_name = file_path.stem
-            labels_file = file_path.parent / f"{base_name}-labels.json"
-
-            with open(labels_file, "w", encoding="utf-8") as file:
-                json.dump(request.data, file, indent=2, ensure_ascii=False)
-
-            return {"success": True, "saved_to": str(labels_file)}
-        except Exception as e:
-            return {"error": str(e)}
-
     @app.get("/chat")
     async def chat_ui():
         # Serve the chat UI
diff --git a/sdk/python/feast/ui_server.py b/sdk/python/feast/ui_server.py
@@ -7,16 +7,10 @@
 from fastapi import FastAPI, Response, status
 from fastapi.middleware.cors import CORSMiddleware
 from fastapi.staticfiles import StaticFiles
-from pydantic import BaseModel
 
 import feast
 
 
-class SaveDocumentRequest(BaseModel):
-    file_path: str
-    data: dict
-
-
 def get_app(
     store: "feast.FeatureStore",
     project_id: str,
@@ -121,26 +115,6 @@ def health():
             else Response(status_code=status.HTTP_503_SERVICE_UNAVAILABLE)
         )
 
-    @app.post("/save-document")
-    async def save_document_endpoint(request: SaveDocumentRequest):
-        try:
-            import os
-            from pathlib import Path
-
-            file_path = Path(request.file_path).resolve()
-            if not str(file_path).startswith(os.getcwd()):
-                return {"error": "Invalid file path"}
-
-            base_name = file_path.stem
-            labels_file = file_path.parent / f"{base_name}-labels.json"
-
-            with open(labels_file, "w", encoding="utf-8") as file:
-                json.dump(request.data, file, indent=2, ensure_ascii=False)
-
-            return {"success": True, "saved_to": str(labels_file)}
-        except Exception as e:
-            return {"error": str(e)}
-
     # For all other paths (such as paths that would otherwise be handled by react router), pass to React
     @app.api_route("/p/{path_name:path}", methods=["GET"])
     def catch_all():
diff --git a/sdk/python/tests/unit/test_ui_server.py b/sdk/python/tests/unit/test_ui_server.py
@@ -161,94 +161,6 @@ def test_registry_endpoint_with_none_data(ui_app_without_registry):
     assertpy.assert_that(response.status_code).is_equal_to(EXPECTED_ERROR_STATUS)
 
 
-def test_save_document_endpoint_success(ui_app_with_registry):
-    """Test the save document endpoint successfully saves data to a labels file.
-
-    This test verifies that the /save-document endpoint correctly processes
-    a valid request, creates a labels file, and returns success confirmation.
-    """
-    client = TestClient(ui_app_with_registry)
-
-    # Create a temporary file in the current working directory for testing
-    with tempfile.NamedTemporaryFile(
-        mode="w", suffix=".py", delete=False, dir=os.getcwd()
-    ) as f:
-        test_file_path = f.name
-        f.write("# Test file content")
-
-    try:
-        request_data = {
-            "file_path": test_file_path,
-            "data": {"test": "data", "key": "value"},
-        }
-
-        response = client.post("/save-document", json=request_data)
-        assertpy.assert_that(response.status_code).is_equal_to(EXPECTED_SUCCESS_STATUS)
-
-        response_data = response.json()
-        assertpy.assert_that(response_data["success"]).is_true()
-        assertpy.assert_that(response_data).contains_key("saved_to")
-
-        # Verify the file was created
-        labels_file = response_data["saved_to"]
-        assertpy.assert_that(os.path.exists(labels_file)).is_true()
-
-        with open(labels_file, "r") as f:
-            saved_data = json.load(f)
-        assertpy.assert_that(saved_data).is_equal_to(request_data["data"])
-
-    finally:
-        # Cleanup
-        if os.path.exists(test_file_path):
-            os.unlink(test_file_path)
-        labels_file = test_file_path.replace(".py", "-labels.json")
-        if os.path.exists(labels_file):
-            os.unlink(labels_file)
-
-
-def test_save_document_endpoint_invalid_path(ui_app_with_registry):
-    """Test the save document endpoint returns error for invalid file path.
-
-    This test verifies that the /save-document endpoint correctly rejects
-    file paths that are outside the current working directory for security.
-    """
-    client = TestClient(ui_app_with_registry)
-
-    request_data = {
-        "file_path": "/invalid/absolute/path/outside/workspace.py",
-        "data": {"test": "data"},
-    }
-
-    response = client.post("/save-document", json=request_data)
-    assertpy.assert_that(response.status_code).is_equal_to(EXPECTED_SUCCESS_STATUS)
-
-    response_data = response.json()
-    assertpy.assert_that(response_data).contains_key("error")
-    assertpy.assert_that(response_data["error"]).contains("Invalid file path")
-
-
-def test_save_document_endpoint_exception_handling(ui_app_with_registry):
-    """Test the save document endpoint handles exceptions gracefully.
-
-    This test verifies that the /save-document endpoint properly catches
-    and returns error responses when exceptions occur during processing.
-    """
-    client = TestClient(ui_app_with_registry)
-
-    # Test with a file path outside the current working directory (will cause an exception)
-    request_data = {
-        "file_path": "/invalid/absolute/path/outside/workspace.py",
-        "data": {"test": "data"},
-    }
-
-    response = client.post("/save-document", json=request_data)
-    assertpy.assert_that(response.status_code).is_equal_to(EXPECTED_SUCCESS_STATUS)
-
-    response_data = response.json()
-    assertpy.assert_that(response_data).contains_key("error")
-    assertpy.assert_that(response_data["error"]).contains("Invalid file path")
-
-
 @pytest.mark.parametrize(
     "registry_available,expected_status",
     [(True, EXPECTED_SUCCESS_STATUS), (False, EXPECTED_ERROR_STATUS)],
