fixed unit test and linter...i believe

franciscojavierarceo · franciscojavierarceo · commit 3cd0093adbf0 · 2025-03-08T20:57:00.000-05:00
Signed-off-by: Francisco Javier Arceo &lt;farceo@redhat.com&gt;
diff --git a/sdk/python/feast/feature_store.py b/sdk/python/feast/feature_store.py
@@ -89,6 +89,8 @@
 from feast.saved_dataset import SavedDataset, SavedDatasetStorage, ValidationReference
 from feast.ssl_ca_trust_store_setup import configure_ca_trust_store_env_variables
 from feast.stream_feature_view import StreamFeatureView
+from feast.transformation.pandas_transformation import PandasTransformation
+from feast.transformation.python_transformation import PythonTransformation
 from feast.utils import _utc_now
 
 warnings.simplefilter("once", DeprecationWarning)
@@ -1552,7 +1554,13 @@ def _get_feature_view_and_df_for_online_write(
             isinstance(feature_view, OnDemandFeatureView)
             and feature_view.write_to_online_store
         ):
-            if feature_view.mode == "python":
+            if (
+                feature_view.mode == "python"
+                and isinstance(
+                    feature_view.feature_transformation, PythonTransformation
+                )
+                and df is not None
+            ):
                 input_dict = (
                     df.to_dict(orient="records")[0]
                     if feature_view.singleton
@@ -1561,7 +1569,8 @@ def _get_feature_view_and_df_for_online_write(
                 transformed_data = feature_view.feature_transformation.udf(input_dict)
                 if feature_view.write_to_online_store:
                     entities = [
-                        self.get_entity(entity) for entity in feature_view.entities
+                        self.get_entity(entity)
+                        for entity in (feature_view.entities or [])
                     ]
                     join_keys = [entity.join_key for entity in entities if entity]
                     join_keys = [k for k in join_keys if k in input_dict.keys()]
@@ -1585,11 +1594,14 @@ def _get_feature_view_and_df_for_online_write(
                         if k not in transformed_data:
                             transformed_data[k] = input_dict[k]
                 df = pd.DataFrame(transformed_data)
-            elif feature_view.mode == "pandas":
+            elif feature_view.mode == "pandas" and isinstance(
+                feature_view.feature_transformation, PandasTransformation
+            ):
                 transformed_df = feature_view.feature_transformation.udf(df)
-                for col in df.columns:
-                    transformed_df[col] = df[col]
-                df = transformed_df
+                if df is not None:
+                    for col in df.columns:
+                        transformed_df[col] = df[col]
+                    df = transformed_df
 
             else:
                 raise Exception("Unsupported OnDemandFeatureView mode")
@@ -1947,7 +1959,9 @@ def retrieve_online_documents_v2(
         for feature in features:
             feature_view_name = feature.split(":")[0]
             if feature_view_name in [fv.name for fv in available_odfv_views]:
-                feature_view = self.get_on_demand_feature_view(feature_view_name)
+                feature_view: Union[OnDemandFeatureView, FeatureView] = (
+                    self.get_on_demand_feature_view(feature_view_name)
+                )
             else:
                 feature_view = self.get_feature_view(feature_view_name)
             feature_view_set.add(feature_view.name)
@@ -1957,7 +1971,7 @@ def retrieve_online_documents_v2(
             f.split(":")[1] for f in features if isinstance(f, str) and ":" in f
         ]
         if len(available_feature_views) == 0:
-            available_feature_views.extend(available_odfv_views)
+            available_feature_views.extend(available_odfv_views)  # type: ignore[arg-type]
 
         requested_feature_view = available_feature_views[0]
         if not requested_feature_view:
diff --git a/sdk/python/feast/infra/passthrough_provider.py b/sdk/python/feast/infra/passthrough_provider.py
@@ -449,7 +449,7 @@ def materialize_single_feature_view(
     def get_historical_features(
         self,
         config: RepoConfig,
-        feature_views: List[FeatureView],
+        feature_views: List[Union[FeatureView, OnDemandFeatureView]],
         feature_refs: List[str],
         entity_df: Union[pd.DataFrame, str],
         registry: BaseRegistry,
diff --git a/sdk/python/feast/infra/provider.py b/sdk/python/feast/infra/provider.py
@@ -242,7 +242,7 @@ def materialize_single_feature_view(
     def get_historical_features(
         self,
         config: RepoConfig,
-        feature_views: List[FeatureView],
+        feature_views: List[Union[FeatureView, OnDemandFeatureView]],
         feature_refs: List[str],
         entity_df: Union[pd.DataFrame, str],
         registry: BaseRegistry,
diff --git a/sdk/python/feast/utils.py b/sdk/python/feast/utils.py
@@ -373,7 +373,7 @@ def _convert_arrow_odfv_to_proto(
             updated_table = pyarrow.RecordBatch.from_arrays(
                 table.columns + [null_column],
                 schema=table.schema.append(
-                    pyarrow.field(feature.name, null_column.type)
+                    pyarrow.field(feature.name, null_column.type)  # type: ignore[attr-defined]
                 ),
             )
             proto_values_by_column[feature.name] = python_values_to_proto_values(
@@ -467,12 +467,15 @@ def _group_feature_refs(
     all_feature_views: List["FeatureView"],
     all_on_demand_feature_views: List["OnDemandFeatureView"],
 ) -> Tuple[
-    List[Tuple["FeatureView", List[str]]], List[Tuple["OnDemandFeatureView", List[str]]]
+    List[Tuple[Union["FeatureView", "OnDemandFeatureView"], List[str]]],
+    List[Tuple["OnDemandFeatureView", List[str]]],
 ]:
     """Get list of feature views and corresponding feature names based on feature references"""
 
     # view name to view proto
-    view_index = {view.projection.name_to_use(): view for view in all_feature_views}
+    view_index: Dict[str, Union["FeatureView", "OnDemandFeatureView"]] = {
+        view.projection.name_to_use(): view for view in all_feature_views
+    }
 
     # on demand view to on demand view proto
     on_demand_view_index: Dict[str, "OnDemandFeatureView"] = {}
@@ -517,7 +520,7 @@ def _group_feature_refs(
         else:
             raise FeatureViewNotFoundException(view_name)
 
-    fvs_result: List[Tuple["FeatureView", List[str]]] = []
+    fvs_result: List[Tuple[Union["FeatureView", "OnDemandFeatureView"], List[str]]] = []
     odfvs_result: List[Tuple["OnDemandFeatureView", List[str]]] = []
 
     for view_name, feature_names in views_features.items():
@@ -1148,7 +1151,7 @@ def _get_online_request_context(
     entityless_case = DUMMY_ENTITY_NAME in [
         entity_name
         for feature_view in feature_views
-        for entity_name in feature_view.entities
+        for entity_name in (feature_view.entities or [])
     ]
 
     return (
