Fixed bug in featurset proto to model conversion in DataflowJobManager (#578)

mrzzy · Zhu Zhanyan · khorshuheng · commit 3c8b2fd4e014 · 2020-04-15T09:35:04.000+08:00
Bug caused by toString() method being used in the conversion lambda instead of
the getName() method.  Since lambda duplicates functionality already
implemented by Feature.fromProto, removing the lambda block in favor
using the method to do the conversion.

Co-authored-by: Zhu Zhanyan &lt;zhu.zhanyan@gojek.com&gt;
diff --git a/core/src/main/java/feast/core/job/dataflow/DataflowJobManager.java b/core/src/main/java/feast/core/job/dataflow/DataflowJobManager.java
@@ -181,16 +181,7 @@ private Job submitDataflowJob(
       ImportOptions pipelineOptions = getPipelineOptions(jobName, featureSetProtos, sink, update);
       DataflowPipelineJob pipelineResult = runPipeline(pipelineOptions);
       List<FeatureSet> featureSets =
-          featureSetProtos.stream()
-              .map(
-                  fsp -> {
-                    FeatureSet featureSet = new FeatureSet();
-                    featureSet.setName(fsp.getSpec().toString());
-                    featureSet.setVersion(fsp.getSpec().getVersion());
-                    featureSet.setProject(new Project(fsp.getSpec().getProject()));
-                    return featureSet;
-                  })
-              .collect(Collectors.toList());
+          featureSetProtos.stream().map(FeatureSet::fromProto).collect(Collectors.toList());
       String jobId = waitForJobToRun(pipelineResult);
       return new Job(
           jobName,
