Skip to content

Commit 2d38c4e

Browse files
davidheryantozhilingc
authored andcommitted
Fix fastavro version used in Feast to avoid Timestamp delta error (#490)
* Fix fastavro version used in feast to 0.22.9 * Print python packages version used when e2e test fails (cherry picked from commit 7586da6)
1 parent 601033f commit 2d38c4e

File tree

3 files changed

+21
-1
lines changed

3 files changed

+21
-1
lines changed

.prow/scripts/test-end-to-end-batch.sh

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -235,6 +235,15 @@ set +e
235235
pytest bq-batch-retrieval.py --junitxml=${LOGS_ARTIFACT_PATH}/python-sdk-test-report.xml
236236
TEST_EXIT_CODE=$?
237237

238+
if [[ ${TEST_EXIT_CODE} != 0 ]]; then
239+
echo "[DEBUG] Printing logs"
240+
ls -ltrh /var/log/feast*
241+
cat /var/log/feast-serving-warehouse.log /var/log/feast-core.log
242+
243+
echo "[DEBUG] Printing Python packages list"
244+
pip list
245+
fi
246+
238247
cd ${ORIGINAL_DIR}
239248
exit ${TEST_EXIT_CODE}
240249

.prow/scripts/test-end-to-end.sh

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -225,5 +225,14 @@ set +e
225225
pytest basic-ingest-redis-serving.py --junitxml=${LOGS_ARTIFACT_PATH}/python-sdk-test-report.xml
226226
TEST_EXIT_CODE=$?
227227

228+
if [[ ${TEST_EXIT_CODE} != 0 ]]; then
229+
echo "[DEBUG] Printing logs"
230+
ls -ltrh /var/log/feast*
231+
cat /var/log/feast-serving-online.log /var/log/feast-core.log
232+
233+
echo "[DEBUG] Printing Python packages list"
234+
pip list
235+
fi
236+
228237
cd ${ORIGINAL_DIR}
229238
exit ${TEST_EXIT_CODE}

sdk/python/setup.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,9 @@
3737
"pandavro==1.5.*",
3838
"protobuf>=3.10",
3939
"PyYAML==5.1.*",
40-
"fastavro==0.*",
40+
# fastavro 0.22.10 and newer will throw this error for e2e batch test:
41+
# TypeError: Timestamp subtraction must have the same timezones or no timezones
42+
"fastavro==0.22.9",
4143
"kafka-python==1.*",
4244
"tabulate==0.8.*",
4345
"toml==0.10.*",

0 commit comments

Comments
 (0)