Skip to content

Commit 2a728db

Browse files
committed
Add missing kafka port in example feast stream config
Incorrectly swapped resources requests and limit
1 parent c54faf4 commit 2a728db

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

infra/charts/feast/README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -195,7 +195,7 @@ feast-core:
195195
feast:
196196
stream:
197197
options:
198-
bootstrapServers: <kafka_sevice_load_balancer_ip_address_1>
198+
bootstrapServers: <kafka_sevice_load_balancer_ip_address_1:31090>
199199
jobs:
200200
runner: DataflowRunner
201201
options:
@@ -355,9 +355,9 @@ to set the minimum and maximum heap. This is an example reasonable value to set
355355
feast-online-serving:
356356
javaOpts: "-Xms2048m -Xmx2048m"
357357
resources:
358-
requests:
359-
memory: "4096Mi"
360358
limits:
359+
memory: "4096Mi"
360+
requests:
361361
memory: "2048Mi"
362362
cpu: "2"
363363
```

infra/charts/feast/README.md.gotmpl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -182,7 +182,7 @@ feast-core:
182182
feast:
183183
stream:
184184
options:
185-
bootstrapServers: <kafka_sevice_load_balancer_ip_address_1>
185+
bootstrapServers: <kafka_sevice_load_balancer_ip_address_1:31090>
186186
jobs:
187187
runner: DataflowRunner
188188
options:
@@ -342,9 +342,9 @@ to set the minimum and maximum heap. This is an example reasonable value to set
342342
feast-online-serving:
343343
javaOpts: "-Xms2048m -Xmx2048m"
344344
resources:
345-
requests:
346-
memory: "4096Mi"
347345
limits:
346+
memory: "4096Mi"
347+
requests:
348348
memory: "2048Mi"
349349
cpu: "2"
350350
```

infra/charts/feast/values-dataflow-runner.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ feast-core:
55
feast:
66
stream:
77
options:
8-
bootstrapServers: <kafka_sevice_load_balancer_ip_address_1>
8+
bootstrapServers: <kafka_sevice_load_balancer_ip_address_1:31090>
99
jobs:
1010
runner: DataflowRunner
1111
options:

0 commit comments

Comments
 (0)