Fix typo in split string length check (#464)

Chen Zhiling · khorshuheng · commit 1ecdf91bd080 · 2020-02-14T16:03:41.000+08:00
diff --git a/sdk/java/src/main/java/com/gojek/feast/RequestUtil.java b/sdk/java/src/main/java/com/gojek/feast/RequestUtil.java
@@ -61,7 +61,7 @@ public static List<FeatureReference> createFeatureRefs(
                   "Feature id '%s' contains invalid version. Expected format: <project>/<feature-name>:<feature-version>.",
                   featureRefString));
         }
-      } else if (projectSplit.length == 1) {
+      } else if (featureSplit.length == 1) {
         name = featureSplit[0];
       } else {
         throw new IllegalArgumentException(
diff --git a/sdk/java/src/test/java/com/gojek/feast/RequestUtilTest.java b/sdk/java/src/test/java/com/gojek/feast/RequestUtilTest.java
@@ -60,7 +60,7 @@ private static Stream<Arguments> provideValidFeatureIds() {
             Arrays.asList(
                 "driver_project/driver_id:1",
                 "driver_project/driver_name:1",
-                "booking_project/driver_name:1"),
+                "booking_project/driver_name"),
             Arrays.asList(
                 FeatureReference.newBuilder()
                     .setProject("driver_project")
@@ -74,7 +74,6 @@ private static Stream<Arguments> provideValidFeatureIds() {
                     .build(),
                 FeatureReference.newBuilder()
                     .setProject("booking_project")
-                    .setVersion(1)
                     .setName("driver_name")
                     .build())));
   }

Original file line number	Diff line number	Diff line change
`@@ -61,7 +61,7 @@ public static List<FeatureReference> createFeatureRefs(`
`61`	`61`	`"Feature id '%s' contains invalid version. Expected format: <project>/<feature-name>:<feature-version>.",`
`62`	`62`	`featureRefString));`
`63`	`63`	`}`
`64`		`- } else if (projectSplit.length == 1) {`
	`64`	`+ } else if (featureSplit.length == 1) {`
`65`	`65`	`name = featureSplit[0];`
`66`	`66`	`} else {`
`67`	`67`	`throw new IllegalArgumentException(`