Skip to content

Commit 17e7dca

Browse files
Chen Zhilingfeast-ci-bot
authored andcommitted
Add PR template (#416)
* Add PR template * Remove line about not using fixes * Add notes about CLA and release notes
1 parent 8bdc38c commit 17e7dca

File tree

1 file changed

+31
-0
lines changed

1 file changed

+31
-0
lines changed

.github/pull_request_template.md

Lines changed: 31 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,31 @@
1+
<!-- Thanks for sending a pull request! Here are some tips for you:
2+
3+
1. Ensure that your code follows our code conventions: https://github.com/gojek/feast/blob/master/docs/contributing.md#code-conventions
4+
2. Run unit tests and ensure that they are passing: https://github.com/gojek/feast/blob/master/docs/contributing.md#running-unit-tests
5+
3. If your change introduces any API changes, make sure to update the integration tests scripts here: https://github.com/gojek/feast/tree/master/tests/e2e
6+
4. Make sure documentation is updated for your PR!
7+
5. Make sure you have signed the CLA https://cla.developers.google.com/clas
8+
9+
-->
10+
11+
**What this PR does / why we need it**:
12+
13+
**Which issue(s) this PR fixes**:
14+
<!--
15+
*Automatically closes linked issue when PR is merged.
16+
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
17+
-->
18+
Fixes #
19+
20+
**Does this PR introduce a user-facing change?**:
21+
<!--
22+
If no, just write "NONE" in the release-note block below.
23+
If yes, a release note is required:
24+
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
25+
26+
For more information about release notes, see kubernetes' guide here:
27+
http://git.k8s.io/community/contributors/guide/release-notes.md
28+
-->
29+
```release-note
30+
31+
```

0 commit comments

Comments
 (0)