Skip to content

Commit 03fa8a0

Browse files
yashghatolyashghatol
committed
test: Move universal offline/online/materialization tests to universal/ directory
Relocates cross-backend parameterized tests from integration/ into the 4-tier folder structure proposed in #6048. Moves: - integration/offline_store/ (10 files) -> universal/offline_store/ - integration/online_store/test_universal_{e2e,online,online_types}.py + test_push_features_to_online_store.py -> universal/online_store/ - integration/online_store/test_hybrid_online_store.py -> unit/ (uses unittest.mock only, no real services) - integration/online_store/test_remote_online_store.py -> integration/permissions/auth/ (auth-scoped, not universal) - integration/materialization/test_universal_materialization.py -> universal/materialization/ Also updates stale path references in: - Makefile (4 paths: cassandra, milvus, qdrant targets) - docs/how-to-guides/adding-or-reusing-tests.md - sdk/python/tests/README.md Closes #6051 Signed-off-by: yashghatol <yashghatol822@gmail.com>
1 parent c9602d8 commit 03fa8a0

23 files changed

Lines changed: 6 additions & 6 deletions

‎Makefile‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -484,8 +484,8 @@ test-python-universal-cassandra: ## Run Python Cassandra integration tests
484484
FULL_REPO_CONFIGS_MODULE=sdk.python.feast.infra.online_stores.cassandra_online_store.cassandra_repo_configuration \
485485
PYTEST_PLUGINS=sdk.python.tests.universal.feature_repos.universal.online_store.cassandra \
486486
python -m pytest -x --integration \
487-
sdk/python/tests/integration/offline_store/test_feature_logging.py \
488-
--ignore=sdk/python/tests/integration/offline_store/test_validation.py \
487+
sdk/python/tests/universal/offline_store/test_feature_logging.py \
488+
--ignore=sdk/python/tests/universal/offline_store/test_dqm_validation.py \
489489
-k "not test_snowflake and \
490490
not test_spark_materialization_consistency and \
491491
not test_universal_materialization"
@@ -574,7 +574,7 @@ test-python-universal-milvus-online: ## Run Python Milvus online store integrati
574574
PYTEST_PLUGINS=sdk.python.tests.universal.feature_repos.universal.online_store.milvus \
575575
python -m pytest -n 8 --integration \
576576
-k "test_retrieve_online_milvus_documents" \
577-
sdk/python/tests --ignore=sdk/python/tests/integration/offline_store/test_dqm_validation.py
577+
sdk/python/tests --ignore=sdk/python/tests/universal/offline_store/test_dqm_validation.py
578578

579579
test-python-universal-singlestore-online: ## Run Python Singlestore online store integration tests
580580
PYTHONPATH='.' \
@@ -594,7 +594,7 @@ test-python-universal-qdrant-online: ## Run Python Qdrant online store integrati
594594
PYTEST_PLUGINS=sdk.python.tests.universal.feature_repos.universal.online_store.qdrant \
595595
python -m pytest -n 8 --integration \
596596
-k "test_retrieve_online_documents" \
597-
sdk/python/tests/integration/online_store/test_universal_online.py
597+
sdk/python/tests/universal/online_store/test_universal_online.py
598598

599599
# To use Couchbase as an offline store, you need to create an Couchbase Capella Columnar cluster on cloud.couchbase.com.
600600
# Modify environment variables COUCHBASE_COLUMNAR_CONNECTION_STRING, COUCHBASE_COLUMNAR_USER, and COUCHBASE_COLUMNAR_PASSWORD

‎docs/how-to-guides/adding-or-reusing-tests.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,7 @@ Docstring tests are primarily smoke tests to make sure imports and setup functio
158158
Let's look at a sample test using the universal repo:
159159

160160
{% tabs %}
161-
{% tab code="sdk/python/tests/integration/offline_store/test_universal_historical_retrieval.py" %}
161+
{% tab code="sdk/python/tests/universal/offline_store/test_universal_historical_retrieval.py" %}
162162
```python
163163
@pytest.mark.integration
164164
@pytest.mark.universal_offline_stores

‎sdk/python/tests/README.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,7 @@ Docstring tests are primarily smoke tests to make sure imports and setup functio
158158
Let's look at a sample test using the universal repo:
159159

160160
{% tabs %}
161-
{% tab code="sdk/python/tests/integration/offline_store/test_universal_historical_retrieval.py" %}
161+
{% tab code="sdk/python/tests/universal/offline_store/test_universal_historical_retrieval.py" %}
162162
```python
163163
@pytest.mark.integration
164164
@pytest.mark.universal_offline_stores

sdk/python/tests/universal/offline_store/.gitkeep renamed to sdk/python/tests/integration/auth/__init__.py

File renamed without changes.

sdk/python/tests/integration/online_store/test_remote_online_store.py renamed to sdk/python/tests/integration/auth/test_remote_online_store.py

File renamed without changes.

sdk/python/tests/integration/online_store/test_hybrid_online_store.py renamed to sdk/python/tests/unit/test_hybrid_online_store.py

File renamed without changes.

sdk/python/tests/universal/online_store/.gitkeep renamed to sdk/python/tests/universal/materialization/__init__.py

File renamed without changes.

sdk/python/tests/integration/materialization/test_universal_materialization.py renamed to sdk/python/tests/universal/materialization/test_universal_materialization.py

File renamed without changes.

‎sdk/python/tests/universal/offline_store/__init__.py‎

Whitespace-only changes.

sdk/python/tests/integration/offline_store/test_dqm_validation.py renamed to sdk/python/tests/universal/offline_store/test_dqm_validation.py

File renamed without changes.

0 commit comments

Comments
 (0)