-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Expand file tree
/
Copy pathdynamodb.py
More file actions
1291 lines (1132 loc) · 50 KB
/
Copy pathdynamodb.py
File metadata and controls
1291 lines (1132 loc) · 50 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
# Copyright 2021 The Feast Authors
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# https://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
import asyncio
import contextlib
import itertools
import logging
from collections import OrderedDict, defaultdict
from concurrent.futures import ThreadPoolExecutor
from datetime import datetime
from typing import Any, Callable, Dict, List, Literal, Optional, Sequence, Tuple, Union
from aiobotocore.config import AioConfig
from pydantic import StrictBool, StrictStr
from feast import Entity, FeatureView, utils
from feast.infra.online_stores.helpers import compute_entity_id, compute_versioned_name
from feast.infra.online_stores.online_store import OnlineStore
from feast.infra.supported_async_methods import SupportedAsyncMethods
from feast.infra.utils.aws_utils import dynamo_write_items_async
from feast.protos.feast.types.EntityKey_pb2 import EntityKey as EntityKeyProto
from feast.protos.feast.types.Value_pb2 import Value as ValueProto
from feast.repo_config import FeastConfigBaseModel, RepoConfig
from feast.utils import get_user_agent
try:
import boto3
from aiobotocore import session
from boto3.dynamodb.types import TypeDeserializer
from botocore.config import Config
from botocore.exceptions import ClientError
except ImportError as e:
from feast.errors import FeastExtrasDependencyImportError
raise FeastExtrasDependencyImportError("aws", str(e))
logger = logging.getLogger(__name__)
class DynamoDBOnlineStoreConfig(FeastConfigBaseModel):
"""Online store config for DynamoDB store"""
type: Literal["dynamodb"] = "dynamodb"
"""Online store type selector"""
batch_size: int = 100
"""Number of items to retrieve in a DynamoDB BatchGetItem call.
DynamoDB supports up to 100 items per BatchGetItem request."""
endpoint_url: Union[str, None] = None
"""DynamoDB endpoint URL. Use for local development (e.g., http://localhost:8000)
or VPC endpoints for improved latency."""
region: StrictStr
"""AWS Region Name"""
table_name_template: StrictStr = "{project}.{table_name}"
"""DynamoDB table name template"""
consistent_reads: StrictBool = False
"""Whether to read from Dynamodb by forcing consistent reads"""
tags: Union[Dict[str, str], None] = None
"""AWS resource tags added to each table"""
session_based_auth: bool = False
"""AWS session based client authentication"""
max_read_workers: int = 10
"""Maximum number of parallel threads for batch read operations.
Higher values improve throughput for large batch reads but increase resource usage."""
max_pool_connections: int = 50
"""Max number of connections for async Dynamodb operations.
Increase for high-throughput workloads."""
keepalive_timeout: float = 30.0
"""Keep-alive timeout in seconds for async Dynamodb connections.
Higher values help reuse connections under sustained load."""
connect_timeout: Union[int, float] = 5
"""The time in seconds until a timeout exception is thrown when attempting to make
an async connection. Lower values enable faster failure detection."""
read_timeout: Union[int, float] = 10
"""The time in seconds until a timeout exception is thrown when attempting to read
from an async connection. Lower values enable faster failure detection."""
total_max_retry_attempts: Union[int, None] = 3
"""Maximum number of total attempts that will be made on a single request.
Maps to `retries.total_max_attempts` in botocore.config.Config.
"""
retry_mode: Union[Literal["legacy", "standard", "adaptive"], None] = "adaptive"
"""The type of retry mode (aio)botocore should use.
Maps to `retries.mode` in botocore.config.Config.
'adaptive' mode provides intelligent retry with client-side rate limiting.
"""
class DynamoDBOnlineStore(OnlineStore):
"""
AWS DynamoDB implementation of the online store interface.
Attributes:
_dynamodb_client: Boto3 DynamoDB client.
_dynamodb_resource: Boto3 DynamoDB resource.
_aioboto_session: Async boto session.
_aioboto_client: Async boto client.
_aioboto_context_stack: Async context stack.
_type_deserializer: Cached TypeDeserializer instance for performance.
"""
_dynamodb_client = None
_dynamodb_resource = None
# Class-level cached TypeDeserializer to avoid per-request instantiation
_type_deserializer: Optional[TypeDeserializer] = None
def __init__(self):
super().__init__()
self._aioboto_session = None
self._aioboto_client = None
self._aioboto_context_stack = None
# Initialize cached TypeDeserializer if not already done
if DynamoDBOnlineStore._type_deserializer is None:
DynamoDBOnlineStore._type_deserializer = TypeDeserializer()
async def initialize(self, config: RepoConfig):
online_config = config.online_store
await self._get_aiodynamodb_client(
online_config.region,
online_config.max_pool_connections,
online_config.keepalive_timeout,
online_config.connect_timeout,
online_config.read_timeout,
online_config.total_max_retry_attempts,
online_config.retry_mode,
online_config.endpoint_url,
)
async def close(self):
await self._aiodynamodb_close()
def _get_aioboto_session(self):
if self._aioboto_session is None:
logger.debug("initializing the aiobotocore session")
self._aioboto_session = session.get_session()
return self._aioboto_session
async def _get_aiodynamodb_client(
self,
region: str,
max_pool_connections: int,
keepalive_timeout: float,
connect_timeout: Union[int, float],
read_timeout: Union[int, float],
total_max_retry_attempts: Union[int, None],
retry_mode: Union[Literal["legacy", "standard", "adaptive"], None],
endpoint_url: Optional[str] = None,
):
if self._aioboto_client is None:
logger.debug("initializing the aiobotocore dynamodb client")
retries: Dict[str, Any] = {}
if total_max_retry_attempts is not None:
retries["total_max_attempts"] = total_max_retry_attempts
if retry_mode is not None:
retries["mode"] = retry_mode
# Build client kwargs, including endpoint_url for VPC endpoints or local testing
client_kwargs: Dict[str, Any] = {
"region_name": region,
"config": AioConfig(
max_pool_connections=max_pool_connections,
connect_timeout=connect_timeout,
read_timeout=read_timeout,
retries=retries if retries else None,
connector_args={"keepalive_timeout": keepalive_timeout},
),
}
if endpoint_url:
client_kwargs["endpoint_url"] = endpoint_url
client_context = self._get_aioboto_session().create_client(
"dynamodb",
**client_kwargs,
)
self._aioboto_context_stack = contextlib.AsyncExitStack()
self._aioboto_client = (
await self._aioboto_context_stack.enter_async_context(client_context)
)
return self._aioboto_client
async def _aiodynamodb_close(self):
if self._aioboto_context_stack:
await self._aioboto_context_stack.aclose()
self._aioboto_context_stack = None
self._aioboto_client = None
if self._aioboto_session:
self._aioboto_session = None
@property
def async_supported(self) -> SupportedAsyncMethods:
return SupportedAsyncMethods(read=True, write=True)
@staticmethod
def _table_tags(online_config, table_instance) -> list[dict[str, str]]:
table_instance_tags = table_instance.tags or {}
online_tags = online_config.tags or {}
common_tags = [
{"Key": key, "Value": table_instance_tags.get(key) or value}
for key, value in online_tags.items()
]
table_tags = [
{"Key": key, "Value": value}
for key, value in table_instance_tags.items()
if key not in online_tags
]
return common_tags + table_tags
@staticmethod
def _update_tags(dynamodb_client, table_name: str, new_tags: list[dict[str, str]]):
"""Update DynamoDB table tags using a diff-based approach.
Instead of removing all tags and re-adding them (which is vulnerable to
the eventual-consistency window between UntagResource and TagResource),
this method computes the minimal set of changes needed:
- Only removes tags that are no longer present in new_tags.
- Only adds/updates tags whose value has changed or that are new.
This avoids the race condition described in
https://github.com/feast-dev/feast/issues/6418 where calling
TagResource immediately after UntagResource can leave a table with no
tags due to DynamoDB's asynchronous tag operations.
"""
table_arn = dynamodb_client.describe_table(TableName=table_name)["Table"][
"TableArn"
]
current_tags = dynamodb_client.list_tags_of_resource(ResourceArn=table_arn)[
"Tags"
]
current_tag_map = {tag["Key"]: tag["Value"] for tag in current_tags}
new_tag_map = {tag["Key"]: tag["Value"] for tag in new_tags}
# Remove only tags that are no longer in new_tags
keys_to_remove = [k for k in current_tag_map if k not in new_tag_map]
# Add / update only tags whose value is new or has changed
tags_to_add = [
{"Key": k, "Value": v}
for k, v in new_tag_map.items()
if current_tag_map.get(k) != v
]
if keys_to_remove:
dynamodb_client.untag_resource(
ResourceArn=table_arn, TagKeys=keys_to_remove
)
if tags_to_add:
dynamodb_client.tag_resource(ResourceArn=table_arn, Tags=tags_to_add)
def update(
self,
config: RepoConfig,
tables_to_delete: Sequence[FeatureView],
tables_to_keep: Sequence[FeatureView],
entities_to_delete: Sequence[Entity],
entities_to_keep: Sequence[Entity],
partial: bool,
):
"""
Update tables from the DynamoDB Online Store.
Args:
config: The RepoConfig for the current FeatureStore.
tables_to_delete: Tables to delete from the DynamoDB Online Store.
tables_to_keep: Tables to keep in the DynamoDB Online Store.
"""
online_config = config.online_store
assert isinstance(online_config, DynamoDBOnlineStoreConfig)
dynamodb_client = self._get_dynamodb_client(
online_config.region,
online_config.endpoint_url,
online_config.session_based_auth,
)
dynamodb_resource = self._get_dynamodb_resource(
online_config.region,
online_config.endpoint_url,
online_config.session_based_auth,
)
do_tag_updates = defaultdict(bool)
for table_instance in tables_to_keep:
# Add Tags attribute to creation request only if configured to prevent
# TagResource permission issues, even with an empty Tags array.
table_tags = self._table_tags(online_config, table_instance)
kwargs = {"Tags": table_tags} if table_tags else {}
table_name = _get_table_name(online_config, config, table_instance)
# Check if table already exists before attempting to create
# This is required for environments where IAM roles don't have
# dynamodb:CreateTable permissions (e.g., Terraform-managed tables)
table_exists = False
try:
dynamodb_client.describe_table(TableName=table_name)
table_exists = True
do_tag_updates[table_name] = True
logger.info(
f"DynamoDB table {table_name} already exists, skipping creation"
)
except ClientError as ce:
if ce.response["Error"]["Code"] != "ResourceNotFoundException":
# If it's not a "table not found" error, re-raise
raise
# Only attempt to create table if it doesn't exist
if not table_exists:
try:
dynamodb_resource.create_table(
TableName=table_name,
KeySchema=[{"AttributeName": "entity_id", "KeyType": "HASH"}],
AttributeDefinitions=[
{"AttributeName": "entity_id", "AttributeType": "S"}
],
BillingMode="PAY_PER_REQUEST",
**kwargs,
)
logger.info(f"Created DynamoDB table {table_name}")
except ClientError as ce:
do_tag_updates[table_name] = True
# If the table creation fails with ResourceInUseException,
# it means the table already exists or is being created.
# Otherwise, re-raise the exception
if ce.response["Error"]["Code"] != "ResourceInUseException":
raise
for table_instance in tables_to_keep:
table_name = _get_table_name(online_config, config, table_instance)
dynamodb_client.get_waiter("table_exists").wait(TableName=table_name)
# once table is confirmed to exist, update the tags.
# tags won't be updated in the create_table call if the table already exists
if do_tag_updates[table_name]:
tags = self._table_tags(online_config, table_instance)
try:
self._update_tags(dynamodb_client, table_name, tags)
except ClientError as ce:
# If tag update fails with AccessDeniedException, log warning and continue
# This allows Feast to work in environments where IAM roles don't have
# dynamodb:TagResource and dynamodb:UntagResource permissions
if ce.response["Error"]["Code"] == "AccessDeniedException":
logger.warning(
f"Unable to update tags for table {table_name} due to insufficient permissions."
)
else:
raise
for table_to_delete in tables_to_delete:
_delete_table_idempotent(
dynamodb_resource,
_get_table_name(online_config, config, table_to_delete),
)
def teardown(
self,
config: RepoConfig,
tables: Sequence[FeatureView],
entities: Sequence[Entity],
):
"""
Delete tables from the DynamoDB Online Store.
Args:
config: The RepoConfig for the current FeatureStore.
tables: Tables to delete from the feature repo.
"""
online_config = config.online_store
assert isinstance(online_config, DynamoDBOnlineStoreConfig)
dynamodb_resource = self._get_dynamodb_resource(
online_config.region,
online_config.endpoint_url,
online_config.session_based_auth,
)
for table in tables:
_delete_table_idempotent(
dynamodb_resource, _get_table_name(online_config, config, table)
)
def online_write_batch(
self,
config: RepoConfig,
table: FeatureView,
data: List[
Tuple[EntityKeyProto, Dict[str, ValueProto], datetime, Optional[datetime]]
],
progress: Optional[Callable[[int], Any]],
) -> None:
"""
Write a batch of feature rows to online DynamoDB store.
Note: This method applies a ``batch_writer`` to automatically handle any unprocessed items
and resend them as needed, this is useful if you're loading a lot of data at a time.
Args:
config: The RepoConfig for the current FeatureStore.
table: Feast FeatureView.
data: a list of quadruplets containing Feature data. Each quadruplet contains an Entity Key,
a dict containing feature values, an event timestamp for the row, and
the created timestamp for the row if it exists.
progress: Optional function to be called once every mini-batch of rows is written to
the online store. Can be used to display progress.
"""
online_config = config.online_store
assert isinstance(online_config, DynamoDBOnlineStoreConfig)
dynamodb_resource = self._get_dynamodb_resource(
online_config.region,
online_config.endpoint_url,
online_config.session_based_auth,
)
table_instance = dynamodb_resource.Table(
_get_table_name(online_config, config, table)
)
self._write_batch_non_duplicates(table_instance, data, progress, config)
async def online_write_batch_async(
self,
config: RepoConfig,
table: FeatureView,
data: List[
Tuple[EntityKeyProto, Dict[str, ValueProto], datetime, Optional[datetime]]
],
progress: Optional[Callable[[int], Any]],
) -> None:
"""
Writes a batch of feature rows to the online store asynchronously.
If a tz-naive timestamp is passed to this method, it is assumed to be UTC.
Args:
config: The config for the current feature store.
table: Feature view to which these feature rows correspond.
data: A list of quadruplets containing feature data. Each quadruplet contains an entity
key, a dict containing feature values, an event timestamp for the row, and the created
timestamp for the row if it exists.
progress: Function to be called once a batch of rows is written to the online store, used
to show progress.
"""
online_config = config.online_store
assert isinstance(online_config, DynamoDBOnlineStoreConfig)
table_name = _get_table_name(online_config, config, table)
items = [
_to_client_write_item(config, entity_key, features, timestamp)
for entity_key, features, timestamp, _ in _latest_data_to_write(data)
]
client = await self._get_aiodynamodb_client(
online_config.region,
online_config.max_pool_connections,
online_config.keepalive_timeout,
online_config.connect_timeout,
online_config.read_timeout,
online_config.total_max_retry_attempts,
online_config.retry_mode,
online_config.endpoint_url,
)
await dynamo_write_items_async(client, table_name, items)
def online_read(
self,
config: RepoConfig,
table: FeatureView,
entity_keys: List[EntityKeyProto],
requested_features: Optional[List[str]] = None,
) -> List[Tuple[Optional[datetime], Optional[Dict[str, ValueProto]]]]:
"""
Retrieve feature values from the online DynamoDB store.
Args:
config: The RepoConfig for the current FeatureStore.
table: Feast FeatureView.
entity_keys: a list of entity keys that should be read from the FeatureStore.
requested_features: Optional list of feature names to retrieve.
"""
online_config = config.online_store
assert isinstance(online_config, DynamoDBOnlineStoreConfig)
dynamodb_resource = self._get_dynamodb_resource(
online_config.region,
online_config.endpoint_url,
online_config.session_based_auth,
)
table_name = _get_table_name(online_config, config, table)
batch_size = online_config.batch_size
entity_ids = self._to_entity_ids(config, entity_keys)
# Split entity_ids into batches upfront
batches: List[List[str]] = []
entity_ids_iter = iter(entity_ids)
while True:
batch = list(itertools.islice(entity_ids_iter, batch_size))
if not batch:
break
batches.append(batch)
if not batches:
return []
# For single batch, no parallelization overhead needed
if len(batches) == 1:
batch_entity_ids = self._to_resource_batch_get_payload(
online_config, table_name, batches[0], requested_features
)
response = dynamodb_resource.batch_get_item(RequestItems=batch_entity_ids)
return self._process_batch_get_response(table_name, response, batches[0])
# Execute batch requests in parallel for multiple batches
# Note: boto3 clients ARE thread-safe, so we can share a single client
# https://docs.aws.amazon.com/boto3/latest/guide/clients.html#multithreading-or-multiprocessing-with-clients
dynamodb_client = self._get_dynamodb_client(
online_config.region,
online_config.endpoint_url,
online_config.session_based_auth,
)
def fetch_batch(batch: List[str]) -> Dict[str, Any]:
batch_entity_ids = self._to_client_batch_get_payload(
online_config, table_name, batch, requested_features
)
return dynamodb_client.batch_get_item(RequestItems=batch_entity_ids)
# Use ThreadPoolExecutor for parallel I/O
max_workers = min(len(batches), online_config.max_read_workers)
with ThreadPoolExecutor(max_workers=max_workers) as executor:
responses = list(executor.map(fetch_batch, batches))
# Process responses and merge results in order
# Client responses need deserialization (unlike resource responses)
if self._type_deserializer is None:
self._type_deserializer = TypeDeserializer()
deserialize = self._type_deserializer.deserialize
def to_tbl_resp(raw_client_response):
return {
"entity_id": deserialize(raw_client_response["entity_id"]),
"event_ts": deserialize(raw_client_response["event_ts"]),
"values": deserialize(raw_client_response["values"]),
}
result: List[Tuple[Optional[datetime], Optional[Dict[str, ValueProto]]]] = []
for batch, response in zip(batches, responses):
batch_result = self._process_batch_get_response(
table_name, response, batch, to_tbl_response=to_tbl_resp
)
result.extend(batch_result)
return result
async def online_read_async(
self,
config: RepoConfig,
table: FeatureView,
entity_keys: List[EntityKeyProto],
requested_features: Optional[List[str]] = None,
) -> List[Tuple[Optional[datetime], Optional[Dict[str, ValueProto]]]]:
"""
Reads features values for the given entity keys asynchronously.
Args:
config: The config for the current feature store.
table: The feature view whose feature values should be read.
entity_keys: The list of entity keys for which feature values should be read.
requested_features: The list of features that should be read.
Returns:
A list of the same length as entity_keys. Each item in the list is a tuple where the first
item is the event timestamp for the row, and the second item is a dict mapping feature names
to values, which are returned in proto format.
"""
online_config = config.online_store
assert isinstance(online_config, DynamoDBOnlineStoreConfig)
batch_size = online_config.batch_size
entity_ids = self._to_entity_ids(config, entity_keys)
entity_ids_iter = iter(entity_ids)
table_name = _get_table_name(online_config, config, table)
# Use cached TypeDeserializer for better performance
if self._type_deserializer is None:
self._type_deserializer = TypeDeserializer()
deserialize = self._type_deserializer.deserialize
def to_tbl_resp(raw_client_response):
return {
"entity_id": deserialize(raw_client_response["entity_id"]),
"event_ts": deserialize(raw_client_response["event_ts"]),
"values": deserialize(raw_client_response["values"]),
}
batches = []
entity_id_batches = []
while True:
batch = list(itertools.islice(entity_ids_iter, batch_size))
if not batch:
break
entity_id_batch = self._to_client_batch_get_payload(
online_config, table_name, batch, requested_features
)
batches.append(batch)
entity_id_batches.append(entity_id_batch)
client = await self._get_aiodynamodb_client(
online_config.region,
online_config.max_pool_connections,
online_config.keepalive_timeout,
online_config.connect_timeout,
online_config.read_timeout,
online_config.total_max_retry_attempts,
online_config.retry_mode,
online_config.endpoint_url,
)
response_batches = await asyncio.gather(
*[
client.batch_get_item(
RequestItems=entity_id_batch,
)
for entity_id_batch in entity_id_batches
]
)
result_batches = []
for batch, response in zip(batches, response_batches):
result_batch = self._process_batch_get_response(
table_name,
response,
batch,
to_tbl_response=to_tbl_resp,
)
result_batches.append(result_batch)
return list(itertools.chain(*result_batches))
def _get_dynamodb_client(
self,
region: str,
endpoint_url: Optional[str] = None,
session_based_auth: Optional[bool] = False,
):
if self._dynamodb_client is None:
self._dynamodb_client = _initialize_dynamodb_client(
region, endpoint_url, session_based_auth
)
return self._dynamodb_client
def _get_dynamodb_resource(
self,
region: str,
endpoint_url: Optional[str] = None,
session_based_auth: Optional[bool] = False,
):
if self._dynamodb_resource is None:
self._dynamodb_resource = _initialize_dynamodb_resource(
region, endpoint_url, session_based_auth
)
return self._dynamodb_resource
def _write_batch_non_duplicates(
self,
table_instance,
data: List[
Tuple[EntityKeyProto, Dict[str, ValueProto], datetime, Optional[datetime]]
],
progress: Optional[Callable[[int], Any]],
config: RepoConfig,
):
"""Deduplicate write batch request items on ``entity_id`` primary key."""
with table_instance.batch_writer(overwrite_by_pkeys=["entity_id"]) as batch:
for entity_key, features, timestamp, created_ts in data:
batch.put_item(
Item=_to_resource_write_item(
config, entity_key, features, timestamp
)
)
if progress:
progress(1)
def _process_batch_get_response(
self,
table_name: str,
response: Dict[str, Any],
batch: List[str],
to_tbl_response: Callable = lambda raw_dict: raw_dict,
) -> List[Tuple[Optional[datetime], Optional[Dict[str, ValueProto]]]]:
"""Process batch get response using O(1) dictionary lookup.
DynamoDB BatchGetItem doesn't return items in a particular order,
so we use a dictionary for O(1) lookup instead of O(n log n) sorting.
This method:
- Uses dictionary lookup instead of sorting for response ordering
- Pre-allocates the result list with None values
- Minimizes object creation in the hot path
Args:
table_name: Name of the DynamoDB table
response: Raw response from DynamoDB batch_get_item
batch: List of entity_ids in the order they should be returned
to_tbl_response: Function to transform raw DynamoDB response items
(used for async client responses that need deserialization)
Returns:
List of (timestamp, features) tuples in the same order as batch
"""
responses_data = response.get("Responses")
if not responses_data:
# No responses at all, return all None tuples
return [(None, None)] * len(batch)
table_responses = responses_data.get(table_name)
if not table_responses:
# No responses for this table, return all None tuples
return [(None, None)] * len(batch)
# Build a dictionary for O(1) lookup instead of O(n log n) sorting
response_dict: Dict[str, Any] = {
tbl_res["entity_id"]: tbl_res
for tbl_res in map(to_tbl_response, table_responses)
}
# Pre-allocate result list with None tuples (faster than appending)
batch_size = len(batch)
result: List[Tuple[Optional[datetime], Optional[Dict[str, ValueProto]]]] = [
(None, None)
] * batch_size
# Process each entity in batch order using O(1) dict lookup
for idx, entity_id in enumerate(batch):
tbl_res = response_dict.get(entity_id)
if tbl_res is not None:
# Parse feature values
features: Dict[str, ValueProto] = {}
values_data = tbl_res["values"]
for feature_name, value_bin in values_data.items():
val = ValueProto()
val.ParseFromString(value_bin.value)
features[feature_name] = val
# Parse timestamp and set result
result[idx] = (
datetime.fromisoformat(tbl_res["event_ts"]),
features,
)
return result
@staticmethod
def _to_entity_ids(config: RepoConfig, entity_keys: List[EntityKeyProto]):
"""Convert entity keys to entity IDs."""
return [
compute_entity_id(
entity_key,
entity_key_serialization_version=config.entity_key_serialization_version,
)
for entity_key in entity_keys
]
@staticmethod
def _to_resource_batch_get_payload(
online_config, table_name, batch, requested_features=None
):
payload: Dict[str, Any] = {
"Keys": [{"entity_id": entity_id} for entity_id in batch],
"ConsistentRead": online_config.consistent_reads,
}
projection = DynamoDBOnlineStore._build_projection_expression(
requested_features
)
if projection:
payload["ProjectionExpression"] = projection["ProjectionExpression"]
payload["ExpressionAttributeNames"] = projection["ExpressionAttributeNames"]
return {table_name: payload}
@staticmethod
def _to_client_batch_get_payload(
online_config, table_name, batch, requested_features=None
):
payload: Dict[str, Any] = {
"Keys": [{"entity_id": {"S": entity_id}} for entity_id in batch],
"ConsistentRead": online_config.consistent_reads,
}
projection = DynamoDBOnlineStore._build_projection_expression(
requested_features
)
if projection:
payload["ProjectionExpression"] = projection["ProjectionExpression"]
payload["ExpressionAttributeNames"] = projection["ExpressionAttributeNames"]
return {table_name: payload}
@staticmethod
def _build_projection_expression(
requested_features: Optional[List[str]],
) -> Optional[Dict[str, Any]]:
if not requested_features:
return None
attr_names: Dict[str, str] = {
"#entity_id": "entity_id",
"#event_ts": "event_ts",
"#vals": "values",
}
projections = ["#entity_id", "#event_ts"]
for i, feat in enumerate(requested_features):
alias = f"#feat{i}"
attr_names[alias] = feat
projections.append(f"#vals.{alias}")
return {
"ProjectionExpression": ", ".join(projections),
"ExpressionAttributeNames": attr_names,
}
def update_online_store(
self,
config: RepoConfig,
table: FeatureView,
data: List[
Tuple[EntityKeyProto, Dict[str, ValueProto], datetime, Optional[datetime]]
],
update_expressions: Dict[str, str],
progress: Optional[Callable[[int], Any]] = None,
) -> None:
"""
Update features in DynamoDB using UpdateItem with custom UpdateExpression.
This method provides DynamoDB-specific list update functionality using
native UpdateItem operations with list_append and other expressions.
Args:
config: The RepoConfig for the current FeatureStore.
table: Feast FeatureView.
data: Feature data to update. Each tuple contains an entity key,
feature values, event timestamp, and optional created timestamp.
update_expressions: Dict mapping feature names to DynamoDB update expressions.
Examples:
- "transactions": "list_append(transactions, :new_val)"
- "recent_items": "list_append(:new_val, recent_items)" # prepend
progress: Optional progress callback function.
"""
online_config = config.online_store
assert isinstance(online_config, DynamoDBOnlineStoreConfig)
dynamodb_resource = self._get_dynamodb_resource(
online_config.region,
online_config.endpoint_url,
online_config.session_based_auth,
)
table_instance = dynamodb_resource.Table(
_get_table_name(online_config, config, table)
)
# Process each entity update
for entity_key, features, timestamp, _ in _latest_data_to_write(data):
entity_id = compute_entity_id(
entity_key,
entity_key_serialization_version=config.entity_key_serialization_version,
)
self._update_item_with_expression(
table_instance,
entity_id,
features,
timestamp,
update_expressions,
config,
)
if progress:
progress(1)
async def update_online_store_async(
self,
config: RepoConfig,
table: FeatureView,
data: List[
Tuple[EntityKeyProto, Dict[str, ValueProto], datetime, Optional[datetime]]
],
update_expressions: Dict[str, str],
progress: Optional[Callable[[int], Any]] = None,
) -> None:
"""
Async version of update_online_store.
"""
online_config = config.online_store
assert isinstance(online_config, DynamoDBOnlineStoreConfig)
table_name = _get_table_name(online_config, config, table)
client = await self._get_aiodynamodb_client(
online_config.region,
online_config.max_pool_connections,
online_config.keepalive_timeout,
online_config.connect_timeout,
online_config.read_timeout,
online_config.total_max_retry_attempts,
online_config.retry_mode,
online_config.endpoint_url,
)
# Process each entity update
for entity_key, features, timestamp, _ in _latest_data_to_write(data):
entity_id = compute_entity_id(
entity_key,
entity_key_serialization_version=config.entity_key_serialization_version,
)
await self._update_item_with_expression_async(
client,
table_name,
entity_id,
features,
timestamp,
update_expressions,
config,
)
if progress:
progress(1)
def _update_item_with_expression(
self,
table_instance,
entity_id: str,
features: Dict[str, ValueProto],
timestamp: datetime,
update_expressions: Dict[str, str],
config: RepoConfig,
):
"""Execute DynamoDB UpdateItem with list operations via read-modify-write."""
# Read existing item to get current values for list operations
existing_values: Dict[str, ValueProto] = {}
item_exists = False
try:
response = table_instance.get_item(Key={"entity_id": entity_id})
if "Item" in response:
item_exists = True
if "values" in response["Item"]:
for feat_name, val_bin in response["Item"]["values"].items():
val = ValueProto()
val.ParseFromString(val_bin.value)
existing_values[feat_name] = val
except ClientError:
pass
# Build final feature values by applying list operations
final_features: Dict[str, ValueProto] = {}
for feature_name, value_proto in features.items():
if feature_name in update_expressions:
final_features[feature_name] = self._apply_list_operation(
existing_values.get(feature_name),
value_proto,
update_expressions[feature_name],
)
else:
final_features[feature_name] = value_proto
# For new items, use put_item
if not item_exists:
item = {
"entity_id": entity_id,
"event_ts": str(utils.make_tzaware(timestamp)),
"values": {k: v.SerializeToString() for k, v in final_features.items()},
}
table_instance.put_item(Item=item)
return
# Build UpdateExpression for existing items
update_expr_parts: list[str] = []
expression_attribute_values: Dict[str, Any] = {}
expression_attribute_names: Dict[str, str] = {
"#values": "values",
"#event_ts": "event_ts",
}