-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Expand file tree
/
Copy pathmain_test.go
More file actions
212 lines (175 loc) · 6.26 KB
/
Copy pathmain_test.go
File metadata and controls
212 lines (175 loc) · 6.26 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
package main
import (
"crypto/rand"
"crypto/rsa"
"crypto/tls"
"crypto/x509"
"crypto/x509/pkix"
"encoding/pem"
"fmt"
"io"
"math/big"
"net"
"net/http"
"os"
"strings"
"syscall"
"testing"
"time"
"github.com/feast-dev/feast/go/internal/feast"
"github.com/feast-dev/feast/go/internal/feast/server/logging"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/mock"
"github.com/stretchr/testify/require"
)
// MockServerStarter is a mock of ServerStarter interface for testing
type MockServerStarter struct {
mock.Mock
}
func (m *MockServerStarter) StartHttpServer(fs *feast.FeatureStore, host string, port int, metricsPort int, writeLoggedFeaturesCallback logging.OfflineStoreWriteCallback, loggingOpts *logging.LoggingOptions) error {
args := m.Called(fs, host, port, metricsPort, writeLoggedFeaturesCallback, loggingOpts)
return args.Error(0)
}
func (m *MockServerStarter) StartGrpcServer(fs *feast.FeatureStore, host string, port int, metricsPort int, writeLoggedFeaturesCallback logging.OfflineStoreWriteCallback, loggingOpts *logging.LoggingOptions) error {
args := m.Called(fs, host, port, metricsPort, writeLoggedFeaturesCallback, loggingOpts)
return args.Error(0)
}
// TestStartHttpServer tests the StartHttpServer function
func TestStartHttpServer(t *testing.T) {
mockServerStarter := new(MockServerStarter)
fs := &feast.FeatureStore{}
host := "localhost"
port := 8080
var writeLoggedFeaturesCallback logging.OfflineStoreWriteCallback
loggingOpts := &logging.LoggingOptions{}
mockServerStarter.On("StartHttpServer", fs, host, port, 9090, mock.AnythingOfType("logging.OfflineStoreWriteCallback"), loggingOpts).Return(nil)
err := mockServerStarter.StartHttpServer(fs, host, port, 9090, writeLoggedFeaturesCallback, loggingOpts)
assert.NoError(t, err)
mockServerStarter.AssertExpectations(t)
}
// TestStartGrpcServer tests the StartGrpcServer function
func TestStartGrpcServer(t *testing.T) {
mockServerStarter := new(MockServerStarter)
fs := &feast.FeatureStore{}
host := "localhost"
port := 9090
var writeLoggedFeaturesCallback logging.OfflineStoreWriteCallback
loggingOpts := &logging.LoggingOptions{}
mockServerStarter.On("StartGrpcServer", fs, host, port, 9090, mock.AnythingOfType("logging.OfflineStoreWriteCallback"), loggingOpts).Return(nil)
err := mockServerStarter.StartGrpcServer(fs, host, port, 9090, writeLoggedFeaturesCallback, loggingOpts)
assert.NoError(t, err)
mockServerStarter.AssertExpectations(t)
}
// TestConstructLoggingService tests the constructLoggingService function
func TestConstructLoggingService(t *testing.T) {
fs := &feast.FeatureStore{}
var writeLoggedFeaturesCallback logging.OfflineStoreWriteCallback
loggingOpts := &logging.LoggingOptions{}
_, err := constructLoggingService(fs, writeLoggedFeaturesCallback, loggingOpts)
assert.NoError(t, err)
// Further assertions can be added here based on the expected behavior of constructLoggingService
}
func TestStartHttpsServerHealthEndpoint(t *testing.T) {
certPath, keyPath := createSelfSignedTLSFiles(t)
host := "127.0.0.1"
port := getFreePort(t)
metricsPort := getFreePort(t)
stop := make(chan os.Signal, 1)
prevNewSignalStopChannel := newSignalStopChannel
newSignalStopChannel = func() (chan os.Signal, func()) {
return stop, func() {}
}
t.Cleanup(func() {
newSignalStopChannel = prevNewSignalStopChannel
})
errCh := make(chan error, 1)
go func() {
errCh <- StartHttpServer(&feast.FeatureStore{}, host, port, metricsPort, nil, &logging.LoggingOptions{}, true, certPath, keyPath)
}()
httpsClient := &http.Client{
Transport: &http.Transport{
TLSClientConfig: &tls.Config{InsecureSkipVerify: true}, //nolint:gosec
},
}
t.Cleanup(httpsClient.CloseIdleConnections)
url := fmt.Sprintf("https://%s:%d/health", host, port)
var (
resp *http.Response
err error
)
require.Eventually(t, func() bool {
resp, err = httpsClient.Get(url)
if err != nil {
return false
}
return true
}, 5*time.Second, 100*time.Millisecond)
require.NoError(t, err)
t.Cleanup(func() {
if resp != nil && resp.Body != nil {
_ = resp.Body.Close()
}
})
body, readErr := io.ReadAll(resp.Body)
require.NoError(t, readErr)
assert.Equal(t, http.StatusOK, resp.StatusCode)
assert.Equal(t, "Healthy", strings.TrimSpace(string(body)))
stop <- syscall.SIGTERM
select {
case startErr := <-errCh:
require.NoError(t, startErr)
case <-time.After(5 * time.Second):
t.Fatal("StartHttpsServer did not shutdown within timeout")
}
}
func TestStartHttpsServerTLSFilesRequired(t *testing.T) {
err := StartHttpServer(&feast.FeatureStore{}, "127.0.0.1", 0, 0, nil, &logging.LoggingOptions{}, true, "", "")
require.Error(t, err)
assert.Contains(t, err.Error(), "--tls-cert-file and --tls-key-file must be provided")
}
func getFreePort(t *testing.T) int {
t.Helper()
listener, err := net.Listen("tcp", "127.0.0.1:0")
require.NoError(t, err)
defer func() {
_ = listener.Close()
}()
addr, ok := listener.Addr().(*net.TCPAddr)
require.True(t, ok)
return addr.Port
}
func createSelfSignedTLSFiles(t *testing.T) (string, string) {
t.Helper()
priv, err := rsa.GenerateKey(rand.Reader, 2048)
require.NoError(t, err)
tmpl := x509.Certificate{
SerialNumber: big.NewInt(1),
Subject: pkix.Name{
CommonName: "localhost",
},
NotBefore: time.Now().Add(-1 * time.Hour),
NotAfter: time.Now().Add(24 * time.Hour),
KeyUsage: x509.KeyUsageKeyEncipherment | x509.KeyUsageDigitalSignature,
ExtKeyUsage: []x509.ExtKeyUsage{x509.ExtKeyUsageServerAuth},
BasicConstraintsValid: true,
DNSNames: []string{"localhost"},
IPAddresses: []net.IP{net.ParseIP("127.0.0.1")},
}
der, err := x509.CreateCertificate(rand.Reader, &tmpl, &tmpl, &priv.PublicKey, priv)
require.NoError(t, err)
certFile, err := os.CreateTemp(t.TempDir(), "feast-test-cert-*.pem")
require.NoError(t, err)
defer func() {
_ = certFile.Close()
}()
keyFile, err := os.CreateTemp(t.TempDir(), "feast-test-key-*.pem")
require.NoError(t, err)
defer func() {
_ = keyFile.Close()
}()
err = pem.Encode(certFile, &pem.Block{Type: "CERTIFICATE", Bytes: der})
require.NoError(t, err)
err = pem.Encode(keyFile, &pem.Block{Type: "RSA PRIVATE KEY", Bytes: x509.MarshalPKCS1PrivateKey(priv)})
require.NoError(t, err)
return certFile.Name(), keyFile.Name()
}