Skip to content

[Style] dashboard CSS 변경#170

Merged
byeolee1221 merged 3 commits intodevelopfrom
김충오
Nov 4, 2024

Hidden character warning

The head ref may contain hidden characters: "\uae40\ucda9\uc624"
Merged

[Style] dashboard CSS 변경#170
byeolee1221 merged 3 commits intodevelopfrom
김충오

Conversation

@ChungO5
Copy link
Copy Markdown
Collaborator

@ChungO5 ChungO5 commented Nov 4, 2024

변경 내용

  • mydashboard, dashboard/{dashboardId} 페이지 화면 스크롤 수정

@ChungO5 ChungO5 self-assigned this Nov 4, 2024
@ChungO5 ChungO5 added the 🎨 Style 코드 스타일 혹은 포맷 등에 관한 커밋 label Nov 4, 2024
@netlify
Copy link
Copy Markdown

netlify bot commented Nov 4, 2024

Deploy Preview for taskify-test-9-4 ready!

Name Link
🔨 Latest commit 3a74b6e
🔍 Latest deploy log https://app.netlify.com/sites/taskify-test-9-4/deploys/6728808eff01820008161801
😎 Deploy Preview https://deploy-preview-170--taskify-test-9-4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Copy Markdown
Collaborator

@byeolee1221 byeolee1221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다. 적용해보니까 기존 스타일을 유지해야 할 곳이 보이는 것 같아서 확인 부탁드립니다.

{(provided) => (
<div
className="flex h-full w-full flex-col p-4 xl:flex-row xl:space-x-4"
className="flex h-full w-full flex-col p-4 xl:flex-row xl:px-0"
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

space-x-4 없애면 데스크탑 버전에서 컬럼 좌우 여백이 사라져서 너무 딱 붙게 됩니다.

{provided.placeholder}
{columnList.length < 10 && (
<div className="my-4 xl:my-0">
<div className="my-4 xl:my-0 xl:px-4">
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

px-4 하나 더 늘어나니까 간격이 너무 띄워지는 것 같아요.

@cccwon2 cccwon2 self-requested a review November 4, 2024 07:36
Copy link
Copy Markdown
Contributor

@cccwon2 cccwon2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다.

Copy link
Copy Markdown
Collaborator

@hyemeeny hyemeeny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다

@byeolee1221 byeolee1221 merged commit c072127 into develop Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🎨 Style 코드 스타일 혹은 포맷 등에 관한 커밋

Projects

Status: 완료

Development

Successfully merging this pull request may close these issues.

4 participants