Skip to content

[Fix] 존재하던 버그 수정 및 스타일 수정 (원님 PR + 혜민님 PR 결합)#167

Merged
byeolee1221 merged 5 commits intodevelopfrom
문창기
Nov 4, 2024

Hidden character warning

The head ref may contain hidden characters: "\ubb38\ucc3d\uae30"
Merged

[Fix] 존재하던 버그 수정 및 스타일 수정 (원님 PR + 혜민님 PR 결합)#167
byeolee1221 merged 5 commits intodevelopfrom
문창기

Conversation

@byeolee1221
Copy link
Copy Markdown
Collaborator

존재하던 버그 수정 및 스타일 수정 (원님 PR + 혜민님 PR 결합)

  • 존재하던 큰 버그를 모두 수정했습니다.
  • 충돌 발생 우려로 인해 원님이 올리셨던 PR과 혜민님이 올리셨던 PR을 결합했습니다.

@byeolee1221 byeolee1221 added the 🐞 Fix 버그 수정에 대한 커밋 label Nov 4, 2024
@byeolee1221 byeolee1221 self-assigned this Nov 4, 2024
@netlify
Copy link
Copy Markdown

netlify bot commented Nov 4, 2024

Deploy Preview for taskify-test-9-4 ready!

Name Link
🔨 Latest commit 1d02dfe
🔍 Latest deploy log https://app.netlify.com/sites/taskify-test-9-4/deploys/67283f033679490008c0681c
😎 Deploy Preview https://deploy-preview-167--taskify-test-9-4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Copy Markdown
Collaborator

@hyemeeny hyemeeny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!

</label>
<div className="relative flex w-full flex-col space-y-[2px] bg-white" ref={dropdownRef}>
<div className="flex h-[50px] w-full items-center justify-between overflow-hidden rounded-lg px-4 ring-1 ring-inset ring-gray03 transition-all focus-within:ring-violet01 focus:outline-none focus:ring-1 focus:ring-inset">
<div className="flex h-[50px] w-[217px] items-center justify-between overflow-hidden rounded-lg px-4 ring-1 ring-inset ring-gray03 transition-all focus-within:ring-violet01 focus:outline-none focus:ring-1 focus:ring-inset">
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

width 값 고정할 시 모바일에서 사이즈 틀어지지 않았나요?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아 그 부분은 반응형으로 수정 반영하겠습니다!

// 컬럼 리스트 초기화 및 설정
useEffect(() => {
if (dashboardId) {
setResetColumnList(dashboardId);
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

컬럼 리스트 초기화를 따로 추가하신건가요?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

네 수정과정에서 대시보드 아이디 바뀔 때 추가했습니다

Copy link
Copy Markdown
Contributor

@cccwon2 cccwon2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다.

@byeolee1221 byeolee1221 merged commit f04a1b8 into develop Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐞 Fix 버그 수정에 대한 커밋

Projects

Status: 완료

Development

Successfully merging this pull request may close these issues.

3 participants