Conversation
cccwon2
requested review from
ChungO5,
byeolee1221,
hongggyelim and
hyemeeny
and removed request for
hongggyelim
✅ Deploy Preview for taskify-test-9-4 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
cccwon2
changed the title
cccwon2
changed the title
✅ Deploy Preview for taskify-codeit-94 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
hongggyelim
reviewed
Nov 4, 2024
| if (isDashboardInfoLoading || isMemberLoading) return null; | ||
|
|
||
| // 실제 표시할 대시보드 정보 | ||
| const displayDashboard = dashboardInfo; |
Collaborator
There was a problem hiding this comment.
별도의 변수명으로 가져와야하는 이유가 있을까요?
hongggyelim
reviewed
Nov 4, 2024
| </label> | ||
| <div className="relative flex w-full flex-col space-y-[2px] bg-white" ref={dropdownRef}> | ||
| <div className="flex h-[50px] w-full items-center justify-between overflow-hidden rounded-lg px-4 ring-1 ring-inset ring-gray03 transition-all focus-within:ring-violet01 focus:outline-none focus:ring-1 focus:ring-inset"> | ||
| <div className="flex h-[50px] w-[217px] items-center justify-between overflow-hidden rounded-lg px-4 ring-1 ring-inset ring-gray03 transition-all focus-within:ring-violet01 focus:outline-none focus:ring-1 focus:ring-inset"> |
Collaborator
There was a problem hiding this comment.
이부분은 input 크기 변경하기로 한건가요?
Collaborator
There was a problem hiding this comment.
네 시안과 다르게 검색하면 해당 드롭다운이 작아져서 고정시켰습니다.
hongggyelim
reviewed
Nov 4, 2024
| {isLoading && ( | ||
| <div className="py-2 text-center"> | ||
| <p className="font-bold text-gray01">카드 불러오는 중...</p> | ||
| </div> |
Collaborator
There was a problem hiding this comment.
로딩 표시가 두 개가 보여서 이부분이 조금 텍스트가 너무 많은것같다는 느낌을 받았습니다
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.