Repository navigation
Conversation
A search reads control bytes one at a time until an empty slot, so its cost follows the run length, which grows fast past half load with linear probing: at 7/8, fevm's account searches averaged 2.7 probes, most of them fingerprint misses. With at most half of the slots filled, fevm's CREATE runs 8% and SELFDESTRUCT 10% fewer cycles; storage-heavy cases are unchanged. Tables take up to twice the slots.
A lookup cannot probe before its hash, and three folded multiplications (a lane per limb pair, then the lanes) put ~12 cycles of multiplier latency there. Fold the two high limbs, rotated four bits, onto the two low ones and multiply once. fevm's account lookups (address keys) and storage keys (two hashes each) get one multiply per hash: CREATE -4.3% and transfers -4.9% cycles. The distribution test still holds for every limb.
A caller that needed a removed entry's value found its slot, read the value and then removed the key, searching twice. `take` searches once; `remove` and `take` share the removal of a found slot.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four changes from fevm's tuning, and the native runner brought up to date with two of them:
clearremoves every entry and keeps the slots for the next use.u256keys hash with one folded multiplication instead of three: the two high limbs, rotated, fold onto the low ones.takeremoves a key and returns its value with one search;removeshares its slot removal.