Repository navigation
Conversation
`step` gets a view of the frame's stack, top word last, so a tracer can see an opcode's operands, such as the address BALANCE or EXTCODEHASH reads. `Step`, `Trace`'s records and the `fevm serve` protocol are unchanged. With `()` the view is erased: the untraced `fevm_conformance` build is byte-identical at -O1 and -O2.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracer::stepgets a read-only view of the frame's stack, top word last:A tracer can now see an opcode's operands, such as the address BALANCE or EXTCODEHASH is about to read. The hook runs before the opcode's own checks, so the stack may hold fewer words than the opcode needs.
Every
stepimpl gains the parameter.Step,Trace's records and thefevm serveprotocol are unchanged.With the
()tracer the view is erased: thefevm_conformancebinary is byte-identical to main's at -O1 and -O2. In thefevmCLI, which also holdsTracecopies, every handler is unchanged, but a few functions outside them come out differently (the untracedapplynow inlinesexecute_message).