Repository navigation
Fix undo of a clearing authorization - #30
Merged
Merged
Conversation
A clearing authorization (address 0) from a signer without an account
journaled `Delegation { existed: false }`, but clearing no code makes no
account. The nonce increment then made it, so undo removed the account
twice and `remove_empty_account` aborted. `simulate` of such a set-code
transaction crashed, as would a host failure after the authorizations or
a failed Amsterdam message preparation.
Return from `delegate_code` without journaling when it clears no code.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
simulateof a set-code transaction aborted when it carried a clearing authorization (address 0) signed by an account that does not exist.delegate_codejournaledDelegation { existed: false }for the clear, but clearing no code makes no account. The nonce increment that follows made it, so undo removed the account twice andremove_empty_accountasserted. A host failure after the authorizations, or a failed Amsterdam message preparation, undoes the same journal.delegate_codenow returns without journaling when it clears no code, asdeploy_codedoes for empty code. Every other journaling site holds to the rule thatexisted: falsemeans the entry's own write made the account.