Repository navigation
Pin Fe master 6ccb3ca8e - #24
Merged
Merged
Conversation
Fe master infers a call's omitted trailing generic arguments and takes `_` for one (argotorg/fe#1990). Its Cargo.lock and Sonatina revision are unchanged.
A call may now give only its leading generic arguments. The handler dispatch writes `self.op_push<1>(c, mut tracer)`, with the fork from the cursor and the tracer from the argument, and the other calls give the fork alone. The compiled interpreter is unchanged.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pins Fe master
6ccb3ca8e, which infers a call's omitted trailing generic arguments and takes_for one (argotorg/fe#1990). Its Cargo.lock and Sonatina revision are unchanged.Calls now give only the generic arguments the compiler can't infer. The handler dispatch writes
self.op_push<1>(c, mut tracer), taking the fork from the cursor and the tracer from the argument, and the slow-path and transaction calls give the fork alone (run_root<F>,apply_in<Osaka>). The compiled interpreter is unchanged.