Repository navigation
Update revm to 43.0.3 - #23
Merged
Merged
Conversation
The differential references and the bench runner move from revm 33.1 to 43.0.3, release v120, with the DUP underflow correction rebased onto it and extended to DUPN (SWAP's is upstream). The reference interprets frames with Osaka's static gas table (`gas_table_spec`), which v43 passes to `run_plain` apart from the host's gas parameters; transient storage is read per account. The bench runner takes `tx_gas_used` and sets the block's new slot number.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the differential references and the bench runner from revm 33.1 to 43.0.3 (release v120).
Our revm fork's halt-classification patch is rebased onto v120 (
sbillig/revmbranchfix-fevm-stack-halt-classification-v43). SWAP's underflow fix is upstream now; DUP still reports a stack too shallow to duplicate as an overflow, so the patch keeps that correction and extends it to DUPN.v43 passes the static gas table to
run_plainseparately from the host's gas parameters. The reference uses Osaka's (gas_table_spec(SpecId::OSAKA)); the defaultgas_table()is Frontier's and would price BALANCE, SLOAD and the other repriced opcodes wrong. Transient storage is now keyed per account. The bench runner readstx_gas_used, which v43 renames, and sets the newBlockEnv::slot_num.This touches the bench runner's case reader next to #22's changes, so whichever lands second needs a small rebase.