Skip to content

Pin Fe master and remove transact_in - #21

Merged
sbillig merged 4 commits into
mainfrom
pin/fe-master
Nov 12, 2026
Merged

sbillig merged 4 commits into
mainfrom
pin/fe-master

Conversation

@sbillig

@sbillig sbillig commented Nov 12, 2026

Copy link
Copy Markdown
Contributor

Pins Fe master aa0a5d806 and its Sonatina, 5632dd63.

Sonatina now builds a moved Transaction in place (fe-lang/sonatina#534), so the conformance driver calls the documented transact and transact_in and Transaction::load go. apply and Session::apply move the buffers and world out and back instead of swapping in Buffers::new() and WorldState::empty() placeholders; Session::apply returns the receipt.

Fe's growable buffers now grow with realloc (argotorg/fe#1983), so the VM test allocator implements it.

A transfer runs about 200 more instructions than with the held Transaction (3,368 vs 3,164): moving the world and buffers in and out.

Fe's "Grow native buffers in place with `realloc`" resizes buffers past
1032 bytes with C's `realloc`, which a program that replaces `malloc`
and `free` must replace too. With it, the CLI smoke's owned-output
check aborted in glibc's `realloc` on this allocator's blocks. Resize by
allocating, copying and releasing, which counts as before.
Fe master now pins Sonatina 5632dd63, which builds a moved
`Transaction` in place (fe-lang/sonatina#534), and grows native buffers
with `realloc` (argotorg/fe#1983). Pin it, its Cargo.lock and its
Sonatina revision.
The conformance driver kept one Transaction and loaded each run's world
into it, because moving the world and buffers through `transact` cost
~17% of a transfer. With Sonatina building the Transaction in place,
reading the lent buffers in place and folding `Buffers::new()`, the
driver runs the documented `transact`, and `transact_in` and
`Transaction::load` go.
`apply` replaced the lent buffers with `Buffers::new()` to move them
into the Transaction, and `Session::apply` replaced its world with
`WorldState::empty()`. Both are `mut` places, which can be moved out
of when reinitialized before returning, so move them and restore
them instead. `Session::apply` returns the receipt.
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-12T04:28:05.980092Z 554b036 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@sbillig
sbillig merged commit 464bd3b into main Nov 12, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant