Skip to content

Check and test fevm on 32-bit targets - #19

Merged
sbillig merged 1 commit into
mainfrom
wasm-portability
Nov 10, 2026
Merged

sbillig merged 1 commit into
mainfrom
wasm-portability

Conversation

@sbillig

@sbillig sbillig commented Nov 10, 2026

Copy link
Copy Markdown
Contributor

ingots/evm didn't type-check for WebAssembly, where usize is 32 bits. Two bounds were 64-bit literals, and main uses the native host's Args, Stdin and Stdout.

The bounds now come from usize::max(), which has the same value on native targets, and main is native-only. Running the tests on wasm also needs the pending wasm backend fixes in Fe and Sonatina.

`ingots/evm` did not check for WebAssembly, where `usize` has 32
bits: two bounds were 64-bit literals, and `main` takes the native
host's `Args`, `Stdin` and `Stdout`.

The bounds come from `usize::max()`, which is the same value natively,
and `main` is native only. The 89 tests pass on both targets.
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-10T20:32:19.072376Z 8602e79 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@sbillig
sbillig merged commit 433c3b6 into main Nov 10, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant