Repository navigation
Check and test fevm on 32-bit targets - #19
Merged
Merged
Conversation
`ingots/evm` did not check for WebAssembly, where `usize` has 32 bits: two bounds were 64-bit literals, and `main` takes the native host's `Args`, `Stdin` and `Stdout`. The bounds come from `usize::max()`, which is the same value natively, and `main` is native only. The 89 tests pass on both targets.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ingots/evmdidn't type-check for WebAssembly, whereusizeis 32 bits. Two bounds were 64-bit literals, andmainuses the native host'sArgs,StdinandStdout.The bounds now come from
usize::max(), which has the same value on native targets, andmainis native-only. Running the tests on wasm also needs the pending wasm backend fixes in Fe and Sonatina.